status
stringclasses 1
value | repo_name
stringclasses 13
values | repo_url
stringclasses 13
values | issue_id
int64 1
104k
| updated_files
stringlengths 10
1.76k
| title
stringlengths 4
369
| body
stringlengths 0
254k
⌀ | issue_url
stringlengths 38
55
| pull_url
stringlengths 38
53
| before_fix_sha
stringlengths 40
40
| after_fix_sha
stringlengths 40
40
| report_datetime
unknown | language
stringclasses 5
values | commit_datetime
unknown |
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,600 | ["dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js"] | [Bug][ui] there are some problem on the workflow relationship page | 1.Time format changed to 2020-08-26 00:00:00
2. The workflow release status and scheduling release status are changed to "online" or "offline"
![image](https://user-images.githubusercontent.com/55787491/91282787-5b4f1a00-e7bc-11ea-87e8-36cadc845f65.png)
3.when '_' exists in the workflow name, the name on the icon does not show '_'
4.change null to ‘_’
![image](https://user-images.githubusercontent.com/55787491/91284581-ab2ee080-e7be-11ea-9473-bd4648bac5ad.png)
5.After clicking Reset, the workflow relationship is not set to the initial state. Such as:
1)select queried workflow
2)hide the name of the workflow, clicking Reset does not restore the initial state
![image](https://user-images.githubusercontent.com/55787491/91284715-ddd8d900-e7be-11ea-9a28-6de179308082.png)
6.The ’Active‘ in the English version should be changed to current selection
![image](https://user-images.githubusercontent.com/55787491/91286569-2abdaf00-e7c1-11ea-8e7a-2d4a6f9ff40c.png)
which version?
-[dev]
| https://github.com/apache/dolphinscheduler/issues/3600 | https://github.com/apache/dolphinscheduler/pull/7129 | 6beae191e2df497b7624728f0208c3a5ab7f0543 | 791ed6de77893d7dec7595e7cfeb775a2122e68c | "2020-08-26T09:32:03Z" | java | "2021-12-02T17:05:45Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,573 | ["dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml"] | [Bug][dao] potential horizontal unauthorized access | ## Description
In the file `dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessInstanceMapper.xml`, there is a method called `queryLastRunningProcess`, the SQL statement in it on line 12 may cause horizontal unauthorized access.
If the caller does not notice this problem, and it provides a `startTime` or `endTime` which is `null`, then it is possible for him to query other user process instances.
```
1. <select id="queryLastRunningProcess" resultType="org.apache.dolphinscheduler.dao.entity.ProcessInstance">
2. select *
3. from t_ds_process_instance
4. where 1=1
5. <if test="states !=null and states.length != 0">
6. and state in
7. <foreach collection="states" item="i" index="index" open="(" separator="," close=")">
8. #{i}
9. </foreach>
10. </if>
11. <if test="startTime!=null and endTime != null ">
12. and process_definition_id=#{processDefinitionId}
13. and (schedule_time <![CDATA[ >= ]]> #{startTime} and schedule_time <![CDATA[ <= ]]> #{endTime}
14. or start_time <![CDATA[ >= ]]> #{startTime} and start_time <![CDATA[ <= ]]> #{endTime})
15. </if>
16. order by start_time desc limit 1
17.</select>
```
| https://github.com/apache/dolphinscheduler/issues/3573 | https://github.com/apache/dolphinscheduler/pull/3880 | 39411ce03b864bc770da220ad6f81df47bd2487b | 9de7d3c7725588393b4e90bef28697dda4b20f5d | "2020-08-22T09:34:59Z" | java | "2020-10-12T02:23:44Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,553 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/util.js"] | [Bug][ui] when edit the work flow,the selected connecting line has no style change,but the others have get bigger (1.3.0版本工作流编辑时被选中的line样式不变,其他未被选中的line变粗) | 工作流定义的时候,通过‘’箭头选择器‘’选中line的时候,被选中的line样式不变,未被选中的其他line样式却变粗,而且当鼠标移入变粗了的未被选中的line时,变粗的line又恢复原样,这样的话当我想删除某一条线的时候,我不知道我选中了哪条line | https://github.com/apache/dolphinscheduler/issues/3553 | https://github.com/apache/dolphinscheduler/pull/3572 | 879feb79b3aa28a6a296b3955b2796f81a0162df | 3b714b15754af240a07fcf6c18d5a780140df21f | "2020-08-19T09:37:58Z" | java | "2020-08-26T01:40:12Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,548 | ["dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue", "dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue"] | [Bug][UI] Monitor gauge chart display blank with same pid | **Describe the bug**
with correct response data , the monitor chart doesn't show as expected.
**Expected behavior**
just show the correct chart rather than blank
the two worker start by docker ,and have the same pid.
worker in different machine has same pid is ok, so the ui show blank is a bug
**Screenshots**
![chart](https://user-images.githubusercontent.com/3156608/90588557-7b0b9e80-e20e-11ea-9df1-641e02ee6298.png)
![response json](https://user-images.githubusercontent.com/3156608/90588551-7810ae00-e20e-11ea-968d-835d1ba3f641.png)
**Which version of Dolphin Scheduler:**
-[1.3.2-preview]
| https://github.com/apache/dolphinscheduler/issues/3548 | https://github.com/apache/dolphinscheduler/pull/3759 | 1c07892fea86f14a5465231b285120c6de8e5f31 | 2a77ac3a840b2b861b2e0bb02bbb1c7936c3cf90 | "2020-08-19T03:31:36Z" | java | "2020-09-17T03:52:43Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,536 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java"] | [Bug][API] If user didn't have tenant,create resource will NPE. | **Describe the bug**
[Bug][API] If user didn't have tenant,create resource will NPE.
**Expected behavior**
A clear and concise description of what you expected to happen.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-[1.3.2-release]
| https://github.com/apache/dolphinscheduler/issues/3536 | https://github.com/apache/dolphinscheduler/pull/3537 | a3f61238f31412f3c1b54e8644a675487eb0132b | 0505ebf45d93fc1518386804ceffa6b36595f9c5 | "2020-08-18T05:23:28Z" | java | "2020-08-18T05:48:54Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,487 | ["sql/upgrade/1.3.3_schema/postgresql/dolphinscheduler_ddl.sql"] | [Bug][API] Creating folders with multiple threads will result in multiple identical folders | Multiple threads calling the API to create folders will result in multiple identical folders。
The API to create folders is expected to be thread-safe
dolphinScheduler version is 1.3.1
![image](https://user-images.githubusercontent.com/32183971/90121929-2cce4980-dd8f-11ea-86e5-bb133ce6a88e.png)
![image](https://user-images.githubusercontent.com/32183971/90122161-7159e500-dd8f-11ea-8ad3-88161044d26b.png)
| https://github.com/apache/dolphinscheduler/issues/3487 | https://github.com/apache/dolphinscheduler/pull/3919 | 3361151155847de080e3c4d07ec0c784a8eae8bf | 5018117edcbe6db128dad9c00e4eb7e9ad8312bf | "2020-08-13T10:04:41Z" | java | "2020-10-16T02:32:30Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,480 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/ZookeeperNodeManager.java"] | [Bug][Server] zookeeper multi directories, tasks cannot be assigned | **Describe the bug**
zookeeper多级目录场景下任务无法分配worker
**To Reproduce**
Steps to reproduce the behavior, for example:
1. 修改配置文件zookeeper.properties
zookeeper.dolphinscheduler.root=/path/to/dolphinscheduler
2. 正常启动master, worker
3. 新建工作流定义, 新建shell节点, echo "hello world"
**Expected behavior**
1.控制台正常显示已注册的master, worker
2.启动任务后, master报错: "fail to execute : xxx due to no suitable worker, current task need to yyy worker group execute"
**Which version of Dolphin Scheduler:**
-[1.3.1.release]
**Additional context**
1.ExecutorDispatcher#dispatch //hostManager.select 根据已经注册的worker, 通过group找到允许执行的worker
2.ZookeeperNodeManager$WorkerGroupNodeListener#dataChanged 监听worker变化
3.错误代码部分
> `
if (event.getType() == TreeCacheEvent.Type.NODE_ADDED) {
logger.info("worker group node : {} added.", path);
String group = parseGroup(path); //格式化获取group出错, 导致无法刷新syncWorkerGroupNodes
Set<String> workerNodes = workerGroupNodes.getOrDefault(group, new HashSet<>());
Set<String> previousNodes = new HashSet<>(workerNodes);
Set<String> currentNodes = registryCenter.getWorkerGroupNodesDirectly(group);
logger.info("currentNodes : {}", currentNodes);
syncWorkerGroupNodes(group, currentNodes);
}
`
> `
private String parseGroup(String path){
String[] parts = path.split("\\/");
if(parts.length != 6){
throw new IllegalArgumentException(String.format("worker group path : %s is not valid, ignore", path));
}
String group = parts[4]; // /dolphinscheduler/nodes/worker/default, 这段代码符合的路径
return group;
}
`
4. 临时修改
`String group = parts[parts.length-2];// 临时修改`
5.问题原因: workerGroupNodes保存worker信息, workerGroupNodes通过dataChange刷新, parseGroup错误导致变量一直无法更新, 最终ExecutorDispatcher#dispatch无法获取worker, 任务无法继续
| https://github.com/apache/dolphinscheduler/issues/3480 | https://github.com/apache/dolphinscheduler/pull/3532 | ad89f433f16d65ddcab3186baa84e14762d03e52 | 0b7b6d4e2a600bb3af36363c4814da6b169317bf | "2020-08-13T06:13:48Z" | java | "2020-08-17T23:09:39Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,478 | ["dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/FileUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/FileUtilsTest.java"] | [Bug][Common] read the file garbled |
When reading the file, no encoding is specified, resulting in garbled code
![image](https://user-images.githubusercontent.com/39816903/90090148-e3153d00-dd55-11ea-9eef-0a60784a153f.png)
![image](https://user-images.githubusercontent.com/39816903/90090344-5919a400-dd56-11ea-8366-64690029847e.png)
| https://github.com/apache/dolphinscheduler/issues/3478 | https://github.com/apache/dolphinscheduler/pull/3479 | 1cf40e1d1e4379e6b50a92871987d59291ccfd50 | bb13f2eae78e4b829816068e8ca3d337d97a0fd2 | "2020-08-13T03:13:35Z" | java | "2020-11-27T13:55:28Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,469 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/filter/ResourceFilter.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ResourcesControllerTest.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/filter/ResourceFilterTest.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java"] | [Bug] The program type of spark node is selected as PYTHON, how should the main jar package be selected? | **Describe the question**
![image](https://user-images.githubusercontent.com/45786444/89966662-459d0900-dc82-11ea-9299-910c9b1745d0.png)
**Which version of DolphinScheduler:**
-[1.3.0]
**Additional context**
The program type of spark node is selected as PYTHON, how should the main jar package be selected?
Because on a linux machine, this command "spark-sumbit *.py" can run spark to run python files.
**Requirement or improvement**
no
| https://github.com/apache/dolphinscheduler/issues/3469 | https://github.com/apache/dolphinscheduler/pull/3498 | e367f90bb73c9682739308a0a98887a1c0f407ef | 5f5c08402fdcecca8c35f4dc3021cc089949ef13 | "2020-08-12T02:09:30Z" | java | "2020-08-14T08:47:01Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,466 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java"] | [Bug][Worker] ZooKeeper path must not end with / character | **Describe the bug**
worker registry path end with / character, so it throws exeption
**To Reproduce**
**Expected behavior**
**Screenshots**
![image](https://user-images.githubusercontent.com/10829956/89892178-de8f3e00-dc08-11ea-9e60-20eaf7dd2273.png)
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/3466 | https://github.com/apache/dolphinscheduler/pull/3470 | d6a32ac65225fa4f8d9a80c09c5ea8a29e392dac | a7a1156ff1002031c87c29bd737d8f9f0488cea1 | "2020-08-11T11:49:59Z" | java | "2020-08-12T09:16:43Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,463 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.java", "dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapperTest.java"] | [Bug][api] rename the udf resource file associated with the udf function, Failed to execute hive task | 1. Rename the udf resource file associated with the udf function
![image](https://user-images.githubusercontent.com/55787491/89854573-ceef0580-dbc6-11ea-90d4-2b4587d37f0f.png)
![image](https://user-images.githubusercontent.com/55787491/89854587-d9a99a80-dbc6-11ea-8b1a-f0b189824287.png)
2. Executing hive task is fail
![image](https://user-images.githubusercontent.com/55787491/89854496-9bac7680-dbc6-11ea-8ab4-e6ab2bd08ed2.png)
**Which version of Dolphin Scheduler:**
-[1.3.2-release] | https://github.com/apache/dolphinscheduler/issues/3463 | https://github.com/apache/dolphinscheduler/pull/3482 | a678c827600d44623f30311574b8226c1c59ace2 | c8322482bbd021a89c407809abfcdd50cf3b2dc6 | "2020-08-11T03:37:09Z" | java | "2020-08-13T08:19:11Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,457 | ["dolphinscheduler-api/src/main/resources/application-api.properties", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/FlinkArgsUtils.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/flink/FlinkTask.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/utils/FlinkArgsUtilsTest.java", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/tasks/flink.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js", "pom.xml"] | [bug] flink args build problem | **Describe the bug**
There was a BUG in the Dolphin Scheduler-1.3.1 that Dolphin set Flink launch parameters
**To Reproduce**
1. If the slot number and taskManager number are set, Jar package cannot be found when flink task is executed
2. Among other parameters, specifying -yqu (the queue name of Flink on Yarn) or -ynm (Flink appName) is invalid
!!!! Setting other boot parameters, such as -yqu and -ynm, can cause confusion in the order in which the flink boot parameters are set
2020-08-10 21:03:31.400 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - Hadoop version: 3.0.0-cdh6.3.2
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - JVM Options:
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -Dlog.file=/opt/flink-1.10.1/log/flink-dscheduler-client-cdh-05.log
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -Dlog4j.configuration=file:/opt/flink-1.10.1/conf/log4j-cli.properties
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -Dlogback.configurationFile=file:/opt/flink-1.10.1/conf/logback.xml
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - Program Arguments:
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - run
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -m
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - yarn-cluster
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -yjm
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - 1G
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -ytm
2020-08-10 21:03:31.401 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - 6G
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -d
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -c
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - cn.~~.analysis.DurationAndMileage
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - analysis-assembly-2.3.jar
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - --qu
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - default
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -yqu
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - test
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - -ynm
2020-08-10 21:03:31.402 10.15.1.19 [main] INFO org.apache.flink.client.cli.CliFrontend - DurationAndMileage
| https://github.com/apache/dolphinscheduler/issues/3457 | https://github.com/apache/dolphinscheduler/pull/4166 | 68541f281d0b0908f605ad49847d3e7acdd5a302 | cbc30b4900215424dcbbfb49539259d32273efc3 | "2020-08-10T12:56:16Z" | java | "2020-12-10T14:37:21Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,431 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/dto/resources/filter/ResourceFilter.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ResourcesControllerTest.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/dto/resources/filter/ResourceFilterTest.java", "dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/upgrade/UpgradeDao.java"] | [Bug][api] After the resource is re-uploaded, the deleted resource directory displayed in the workflow definition is incorrect | 1.Upgrade from 1.2.0 to 1.3.2, Re-upload the file in the resource center
![image](https://user-images.githubusercontent.com/55787491/89607356-eb2c3300-d8a4-11ea-9f1d-e1c41e09ba75.png)
2. View the task resources of the workflow definition,display multiple deleted resources directories
![image](https://user-images.githubusercontent.com/55787491/89607195-7eb13400-d8a4-11ea-9667-d46b51cb2678.png)
**Which version of Dolphin Scheduler:**
-[1.3.2-release] | https://github.com/apache/dolphinscheduler/issues/3431 | https://github.com/apache/dolphinscheduler/pull/3498 | e367f90bb73c9682739308a0a98887a1c0f407ef | 5f5c08402fdcecca8c35f4dc3021cc089949ef13 | "2020-08-07T03:58:50Z" | java | "2020-08-14T08:47:01Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,393 | ["dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/subdirectory/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/udf/pages/resource/_source/list.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileChildReUpdate.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileReUpload.vue", "dolphinscheduler-ui/src/js/module/components/nav/nav.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [Bug][api] view the log of the subtask, prompt "task instance does not exist" | Click "View Log" of the subtask, prompt "The task instance does not exist"
![image](https://user-images.githubusercontent.com/55787491/89242261-b36a8480-d633-11ea-82de-ca2988c41d2e.png)
**Which version of Dolphin Scheduler:**
-[1.3.2-release]
| https://github.com/apache/dolphinscheduler/issues/3393 | https://github.com/apache/dolphinscheduler/pull/3394 | 811fd48f0a27b3112092b4f8b4fbeb5d55cf2da0 | 78672b035900d5d06f1f66af73f2ee41f87086ca | "2020-08-04T01:22:02Z" | java | "2020-08-04T03:40:49Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,369 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ExecutorController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataSourceServiceImpl.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ExecutorServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/DataSourceServiceTest.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ExecutorService2Test.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ExecutorServiceTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"] | [Improvement][api] Introduce interface about api module service | **Describe the question**
Introduce interface about api module service for clearly service module.
**What are the current deficiencies and the benefits of improvement**
- A clear and concise service will help contributor or user to ready the code and locate the function.
**Which version of DolphinScheduler:**
-[dev]
**Describe alternatives you've considered**
Introduce service interface
| https://github.com/apache/dolphinscheduler/issues/3369 | https://github.com/apache/dolphinscheduler/pull/4759 | 9ae29a756f0aeed894c80f5e495d786ccf03f41f | 15a5b0588399bbafd201405af02d611d548fac12 | "2020-07-31T13:52:28Z" | java | "2021-02-18T15:27:37Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,364 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/process/ResourceInfo.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"] | After update the version from 1.2.0 to 1.3.1,running the spark task fail because the can't find the jar | *For better global communication, please give priority to using English description, thx! *
*Please review https://dolphinscheduler.apache.org/en-us/docs/development/issue.html when describe an issue.*
**Describe the question**
1.2.0升级1.3.1 由于任务Json格式变更导致Spark任务找不到Jar包 任务报错 ClassNotFound
即便应用了升级Mysql脚本 Json格式也没有变成1.3可以识别的Json格式 升级脚本是否没有对Spark任务 做升级变更处理???
又或者是1.3.1没有兼容1.2.0的任务????
导致我必须 把所有Spark类型的任务 都要重新编辑一下 保存 刷新成1.3.1的Json格式才可以执行。。。
**Which version of DolphinScheduler:**
-[1.3.1-preview]
**Additional context**
**Requirement or improvement**
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/3364 | https://github.com/apache/dolphinscheduler/pull/3378 | ff99ef383f647627dc13cfb71f5dd3c9b26ea76c | 3744167d52a52892b5ff98d3b07ab250970fdb5d | "2020-07-31T03:56:02Z" | java | "2020-08-03T02:31:27Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,338 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/formModel/formModel.vue", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/udp/udp.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [But][ui] No warning when user do not fill the node blank | **Describe the question**
When I want to confirm and save an no-configured node, it will show nothing warning.
**What are the current deficiencies and the benefits of improvement**
- It can help user to fill the required blank.
**Which version of DolphinScheduler:**
-[dev]
**Describe alternatives you've considered**
Add the warning.
| https://github.com/apache/dolphinscheduler/issues/3338 | https://github.com/apache/dolphinscheduler/pull/3349 | 78856fb08e512b62ab7b24c809407616b2b4bbc5 | a532d8ed69e41c69c4979eae0c1b964891abc696 | "2020-07-28T14:44:03Z" | java | "2020-07-30T05:14:05Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,327 | ["dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/taskInstance/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/list/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/file/pages/subdirectory/_source/list.vue", "dolphinscheduler-ui/src/js/conf/home/pages/resource/pages/udf/pages/resource/_source/list.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileChildReUpdate.vue", "dolphinscheduler-ui/src/js/module/components/fileUpdate/fileReUpload.vue", "dolphinscheduler-ui/src/js/module/components/nav/nav.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [Improvement][api] resource file content update | used dolphin-scheduler V1.3.1,
resource file content update interface only arguments of type "String" are supported, if need update a jar file content, you must delete this file first, then upload again.
if a task depends on it, that will get worse. you must delete this task or remove depends, otherwise, you will get an exception.
| https://github.com/apache/dolphinscheduler/issues/3327 | https://github.com/apache/dolphinscheduler/pull/3394 | 811fd48f0a27b3112092b4f8b4fbeb5d55cf2da0 | 78672b035900d5d06f1f66af73f2ee41f87086ca | "2020-07-28T02:30:04Z" | java | "2020-08-04T03:40:49Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,324 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"] | [Bug][Master] there exists some problems in checking task dependency | **Describe the bug**
There exists some problems in Master-Server executing logic. Some nodes could execute normally though their depenpency is not satisfied. Just like the screenshots below, if you get the same work flow, and you will find the result is wrong.
**Screenshots**
As you can see, task B shouldn't be executed which is the opposite of the result. When task X has condition-type node after, the tasks that depend on X will be probably executed.
![微信图片_20200727231746](https://user-images.githubusercontent.com/37466734/88561201-ac56db80-d061-11ea-9950-69cbeb4d5958.png)
**Which version of Dolphin Scheduler:**
-[1.3.2-snapshot]
**Probable reason**
- it's wrong because of the code below in the red rectangle.
![微信图片_20200727231733](https://user-images.githubusercontent.com/37466734/88561285-c8f31380-d061-11ea-966f-1b6a246021fc.png)
| https://github.com/apache/dolphinscheduler/issues/3324 | https://github.com/apache/dolphinscheduler/pull/3473 | 927985c012342f0c9f1dde397d66b5737571fed2 | 5756d6b02910d139f00b4b412078f32c5ca14c54 | "2020-07-27T15:35:45Z" | java | "2020-08-13T11:02:14Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,314 | ["dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/ZookeeperNodeManagerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackServiceTest.java", "pom.xml"] | [Question] Why "Failed to load ApplicationContext" when running tests locally | # Why "Failed to load ApplicationContext" when running tests locally
The first is the test command I ran:
```
mvn test -pl dolphinscheduler-server -Dtest =TaskPriorityQueueConsumerTest#testSHELLTask
```
It should be noted that the above test is not the only one with this problem.
## The environment in which the problem occurs
The problem was originally discovered by running tests in IDEA, but also by testing directly with the 'mvn' command.
- Operating system: MacOS
- JAVA: 1.8.0_111
- Maven: 3.5.2
- DS version: dev branch
To verify that it was a local environment problem, I created a new virtual machine to test, which had the same problem.
- Operating system: CentOS 7
- JAVA: 1.8.0_221
- Maven: 3.6.3
- DS version: dev branch
## Action steps
I tested it on my virtual machine using the following steps:
```
git clone ...
cd incubator-dolphinscheduler-github/
git checkout dev
mvn clean install -pl dolphinscheduler-common -am -Dmaven.test.skip=true
mvn clean install -pl dolphinscheduler-dao -am -Dmaven.test.skip=true
mvn clean install -pl dolphinscheduler-service -am -Dmaven.test.skip=true
mvn clean install -pl dolphinscheduler-alert -am -Dmaven.test.skip=true
mvn test -pl dolphinscheduler-server -Dtest=TaskPriorityQueueConsumerTest#testSHELLTask
```
## Error log
```
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 15.247 s <<< FAILURE! - in org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumerTest
[ERROR] testSHELLTask(org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumerTest) Time elapsed: 0 s <<< ERROR!
java.lang.IllegalStateException: Failed to load ApplicationContext
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'nettyExecutorManager': Unsatisfied dependency expressed through field 'zookeeperNodeManager'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperNodeManager': Unsatisfied dependency expressed through field 'registryCenter'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperNodeManager': Unsatisfied dependency expressed through field 'registryCenter'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperRegistryCenter': Unsatisfied dependency expressed through field 'zookeeperCachedOperator'; nested exception is org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
Caused by: org.springframework.beans.factory.UnsatisfiedDependencyException: Error creating bean with name 'zookeeperCachedOperator': Unsatisfied dependency expressed through field 'zookeeperClient'; nested exception is org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
Caused by: org.springframework.beans.factory.NoSuchBeanDefinitionException: No qualifying bean of type 'org.apache.dolphinscheduler.service.zk.CuratorZookeeperClient' available: expected at least 1 bean which qualifies as autowire candidate. Dependency annotations: {@org.springframework.beans.factory.annotation.Autowired(required=true)}
01:07:48.958 [SessionTracker] INFO org.apache.zookeeper.server.SessionTrackerImpl - SessionTrackerImpl exited loop!
[INFO]
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] TaskPriorityQueueConsumerTest.testSHELLTask » IllegalState Failed to load Appl...
[INFO]
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 48.206 s
[INFO] Finished at: 2020-07-27T01:07:49Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.22.1:test (default-test) on project dolphinscheduler-server: There are test failures.
[ERROR]
[ERROR] Please refer to /root/incubator-dolphinscheduler-github/dolphinscheduler-server/target/surefire-reports for the individual test results.
[ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
```
## Problem analysis
According to my own knowledge, I tried to solve the above problems. Because the reason is that `Autowired` errors, so I according to the prompt in the test code `dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java`, To annotate `@ContextConfiguration` added a class `CuratorZookeeperClient.class`, problem is solved.
Just like this:
```java
@ContextConfiguration(classes={DependencyConfig.class, SpringApplicationContext.class, SpringZKServer.class,
NettyExecutorManager.class, ExecutorDispatcher.class, ZookeeperRegistryCenter.class, TaskPriorityQueueConsumer.class,
ZookeeperNodeManager.class, ZookeeperCachedOperator.class, ZookeeperConfig.class, MasterConfig.class,
CuratorZookeeperClient.class})
```
I mentioned this problem with more than one test code, but I'll summarize it now:
> if the test code needs to Autowired class A objects, class A needs to Autowired class B objects. Then `A.class` appears in the context configuration, while `B.class` is not, an 'Failed to load ApplicationContext' exception will appear and the test will fail.
## Question
Every time the project merges new code, it will be tested automatically. Why is this test enough to pass without these problems?
| https://github.com/apache/dolphinscheduler/issues/3314 | https://github.com/apache/dolphinscheduler/pull/3304 | b555d0a086c88c29b40304802589b3ef77955ab9 | 3a0d4da27e6f981ecba7d061bad4644079ae122d | "2020-07-27T02:02:58Z" | java | "2020-07-30T05:28:27Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,299 | ["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/AlertDao.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/AlertManager.java"] | [Bug][Alert] when master or worker shutdown, alert cannot notify | This error log:
`[ERROR] 2020-07-22 11:00:22.209 org.apache.dolphinscheduler.common.utils.JSONUtils:[145] - parse list exception!
com.fasterxml.jackson.databind.JsonMappingException: Unexpected character (''' (code 39)): was expecting double-quote to start field name
at [Source: (String)"[{'type':'WORKER','host':'/dolphinscheduler/nodes/worker/hadoop/192.168.0.3:5678','event':'server down','warning level':'serious'}]"; line: 1, column: 2] (through reference chain: java.util.ArrayList[0])
at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:394)
at com.fasterxml.jackson.databind.JsonMappingException.wrapWithPath(JsonMappingException.java:365)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:302)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:245)
at com.fasterxml.jackson.databind.deser.std.CollectionDeserializer.deserialize(CollectionDeserializer.java:27)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4013)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3042)
at org.apache.dolphinscheduler.common.utils.JSONUtils.toList(JSONUtils.java:143)`
I think the reason for this is that Jackson can't parse JSON fields with single quotes. | https://github.com/apache/dolphinscheduler/issues/3299 | https://github.com/apache/dolphinscheduler/pull/3552 | d30bc7bcf3dda45672845130e04212dfec9f0133 | 2f0102580268ff045e6042c3a691f1dee4c49962 | "2020-07-24T06:06:25Z" | java | "2020-08-19T08:27:39Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,298 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java", "dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/utils/ChannelUtils.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistryTest.java"] | [Bug][k8s]when recreate or upgrade helm release, the host ip changed | **Describe the bug**
When DS was deployed to k8s by helm, if you upgrade the release or recreate the release, the ip of worker server and other server will be changed, so when you try to query the log of history task, you will get empty log.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. deploy the cluster use helm
2. recreate the deployed release or just upgrade
3. query a task which runned before upgrade/recreate
4. no log will show
**Expected behavior**
log should be show
**Screenshots**
![image](https://user-images.githubusercontent.com/3021207/88361996-915c4100-cdad-11ea-8e45-1c46b69109ce.png)
**Which version of Dolphin Scheduler:**
-[1.3.1-release]
**Additional context**
**Requirement or improvement**
| https://github.com/apache/dolphinscheduler/issues/3298 | https://github.com/apache/dolphinscheduler/pull/4786 | 23591b71a2859021e9280899b1f1b6ff3b679fbc | 8ebddc1f5bb484a2d7d8e1353b2a8f51fae78ec0 | "2020-07-24T05:00:07Z" | java | "2021-02-18T03:41:58Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,295 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/SchedulerController.java"] | When I create a scheduler directly through the api, a NullPointerException will appear when the processInstancePriority field is not passed. he is @RequestParam(value = "processInstancePriority", required = false) |
![image](https://user-images.githubusercontent.com/34977303/88355113-e1c7a480-cd95-11ea-8cfa-9d34d866cb08.png)
error line
![image](https://user-images.githubusercontent.com/34977303/88355156-10457f80-cd96-11ea-8e3f-31170d6fdff6.png)
Do you need to modify it to @RequestParam(value = "processInstancePriority", required = true) | https://github.com/apache/dolphinscheduler/issues/3295 | https://github.com/apache/dolphinscheduler/pull/3341 | 5f725aa28b2edbd246480a554ac7822bf07fbbfd | e2a117032de53a206fd0d8a55b665a199efb276a | "2020-07-24T02:12:26Z" | java | "2020-07-29T11:01:53Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,262 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HttpUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClient.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/HttpUtilsTest.java", "dolphinscheduler-common/src/test/java/org/apache/dolphinscheduler/common/utils/KerberosHttpClientTest.java", "pom.xml"] | [Bug][dolphinscheduler-common] When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled | When you request the URL through applicationID to get the application status, you cannot get it if Kerberos authentication is enabled
eg:
![image](https://user-images.githubusercontent.com/59079269/88059613-b0818580-cb97-11ea-892b-3c3f94c32652.png)
yarn.application.status.address=http://ark1:8088/ws/v1/cluster/apps/%s
| https://github.com/apache/dolphinscheduler/issues/3262 | https://github.com/apache/dolphinscheduler/pull/3264 | 232a24441bbb559c18739a74abb69ecdb718e158 | 5584f0cb4d27e3ae64ec28c65a8669b38c75d188 | "2020-07-21T13:20:54Z" | java | "2020-08-10T07:18:01Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,256 | ["sql/upgrade/1.2.0_schema/mysql/dolphinscheduler_dml.sql", "sql/upgrade/1.3.0_schema/mysql/dolphinscheduler_dml.sql", "sql/upgrade/1.3.0_schema/postgresql/dolphinscheduler_dml.sql"] | admin account modify report error, caused by mobile phone | >
>
> 我安装1.2.1也不能修改管理员密码,提示request parameter xx is not valid
我这边安装的版本是1.3.1,在进行修改管理原密码的时候,也是提示跟你同样的问题;后面通过F12,查询相应信息,发现这个错误是‘手机’这个信息产生影响的,你必须将该‘手机’参数修改为正确的格式,否则无法正常修改密码,如
![图片](https://user-images.githubusercontent.com/49484750/88007828-62da2e00-cb41-11ea-8804-9ebaacc690e2.png)
_Originally posted by @wjf989 in https://github.com/apache/incubator-dolphinscheduler/issues/219#issuecomment-661597078_
建议:将“手机”的参数变量,同其他地方的变量信息进行脱钩; | https://github.com/apache/dolphinscheduler/issues/3256 | https://github.com/apache/dolphinscheduler/pull/3425 | 2b990e1f000ba583504585624591e8403958c374 | f784ce504f06d8a6b444a98ead01c6aa8b184679 | "2020-07-21T03:04:22Z" | java | "2020-08-07T02:20:56Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,240 | ["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/UdfFunc.java", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/entity/UdfFuncTest.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/entity/SQLTaskExecutionContext.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/entity/SQLTaskExecutionContextTest.java", "pom.xml"] | [Bug][worker] Cannot find a (Map) Key deserializer for type | When I execute SQL query task, JSON parsing error
error info :
````
com.fasterxml.jackson.databind.exc.InvalidDefinitionException:
Cannot find a (Map) Key deserializer for type [simple type, class org.apache.dolphinscheduler.dao.entity.UdfFunc]
`````
![image](https://user-images.githubusercontent.com/39816903/87851699-ecb1ad80-c92d-11ea-8c3d-820f38f5d68d.png)
show code :
TaskExecutionContext taskExecutionContext = JSONUtils.parseObject(contextJson, TaskExecutionContext.class);
![image](https://user-images.githubusercontent.com/39816903/87851753-69448c00-c92e-11ea-94e0-36b45135e533.png)
contextJson:
```
{
"taskInstanceId":2,
"taskName":"SQL-QUERY",
"startTime":"2020-07-18 19:18:58",
"taskType":"SQL",
"host":null,
"executePath":"/tmp/dolphinscheduler/exec/process/2/17/2/2",
"logPath":null,
"taskJson":"{"id":"tasks-5736","name":"SQL-QUERY","desc":null,"type":"SQL","runFlag":"NORMAL","loc":null,"maxRetryTimes":0,"retryInterval":1,"params":{"type":"MYSQL","datasource":3,"sql":"SELECT * FROM person","udfs":"","sqlType":"0","title":"SQL-QUERY","receivers":"[email protected]","receiversCc":"","showType":"TABLE","localParams":[],"connParams":"","preStatements":[],"postStatements":[]},"preTasks":[],"extras":null,"depList":[],"dependence":{},"conditionResult":{"successNode":[""],"failedNode":[""]},"taskInstancePriority":"MEDIUM","workerGroup":"default","workerGroupId":null,"timeout":{"strategy":"","interval":null,"enable":false},"conditionsTask":false,"forbidden":false,"taskTimeoutParameter":{"enable":false,"strategy":null,"interval":0}}",
"processId":0,
"appIds":null,
"processInstanceId":2,
"scheduleTime":null,
"globalParams":null,
"executorId":2,
"cmdTypeIfComplement":0,
"tenantCode":"sysadmin",
"queue":"default",
"processDefineId":17,
"projectId":2,
"taskParams":null,
"envFile":null,
"definedParams":null,
"taskAppId":null,
"taskTimeoutStrategy":0,
"taskTimeout":0,
"workerGroup":"default",
"resources":{
},
"sqlTaskExecutionContext":{
"warningGroupId":0,
"connectionParams":"{"type":null,"address":"jdbc:mysql://127.0.0.1:3306","database":"test","jdbcUrl":"jdbc:mysql://127.0.0.1:3306/test","user":"root","password":"IUAjJCVeJipyb290"}",
"udfFuncTenantCodeMap":null
},
"dataxTaskExecutionContext":{
"dataSourceId":0,
"sourcetype":0,
"sourceConnectionParams":null,
"dataTargetId":0,
"targetType":0,
"targetConnectionParams":null
},
"dependenceTaskExecutionContext":null,
"sqoopTaskExecutionContext":{
"dataSourceId":0,
"sourcetype":0,
"sourceConnectionParams":null,
"dataTargetId":0,
"targetType":0,
"targetConnectionParams":null
},
"procedureTaskExecutionContext":{
"connectionParams":null
}
}
```
test unit :
```
public class TaskExecuteProcessorTest {
@Test
public void testJson(){
String contextJson = "{\n" +
" \"taskInstanceId\":2,\n" +
" \"taskName\":\"SQL-QUERY\",\n" +
" \"startTime\":\"2020-07-18 19:18:58\",\n" +
" \"taskType\":\"SQL\",\n" +
" \"host\":null,\n" +
" \"executePath\":\"/tmp/dolphinscheduler/exec/process/2/17/2/2\",\n" +
" \"logPath\":null,\n" +
" \"taskJson\":\"{\"id\":\"tasks-5736\",\"name\":\"SQL-QUERY\",\"desc\":null,\"type\":\"SQL\",\"runFlag\":\"NORMAL\",\"loc\":null,\"maxRetryTimes\":0,\"retryInterval\":1,\"params\":{\"type\":\"MYSQL\",\"datasource\":3,\"sql\":\"SELECT * FROM person\",\"udfs\":\"\",\"sqlType\":\"0\",\"title\":\"SQL-QUERY\",\"receivers\":\"[email protected]\",\"receiversCc\":\"\",\"showType\":\"TABLE\",\"localParams\":[],\"connParams\":\"\",\"preStatements\":[],\"postStatements\":[]},\"preTasks\":[],\"extras\":null,\"depList\":[],\"dependence\":{},\"conditionResult\":{\"successNode\":[\"\"],\"failedNode\":[\"\"]},\"taskInstancePriority\":\"MEDIUM\",\"workerGroup\":\"default\",\"workerGroupId\":null,\"timeout\":{\"strategy\":\"\",\"interval\":null,\"enable\":false},\"conditionsTask\":false,\"forbidden\":false,\"taskTimeoutParameter\":{\"enable\":false,\"strategy\":null,\"interval\":0}}\",\n" +
" \"processId\":0,\n" +
" \"appIds\":null,\n" +
" \"processInstanceId\":2,\n" +
" \"scheduleTime\":null,\n" +
" \"globalParams\":null,\n" +
" \"executorId\":2,\n" +
" \"cmdTypeIfComplement\":0,\n" +
" \"tenantCode\":\"sysadmin\",\n" +
" \"queue\":\"default\",\n" +
" \"processDefineId\":17,\n" +
" \"projectId\":2,\n" +
" \"taskParams\":null,\n" +
" \"envFile\":null,\n" +
" \"definedParams\":null,\n" +
" \"taskAppId\":null,\n" +
" \"taskTimeoutStrategy\":0,\n" +
" \"taskTimeout\":0,\n" +
" \"workerGroup\":\"default\",\n" +
" \"resources\":{\n" +
"\n" +
" },\n" +
" \"sqlTaskExecutionContext\":{\n" +
" \"warningGroupId\":0,\n" +
" \"connectionParams\":\"{\"type\":null,\"address\":\"jdbc:mysql://127.0.0.1:3306\",\"database\":\"test\",\"jdbcUrl\":\"jdbc:mysql://127.0.0.1:3306/test\",\"user\":\"root\",\"password\":\"IUAjJCVeJipyb290\"}\",\n" +
" \"udfFuncTenantCodeMap\":null\n" +
" },\n" +
" \"dataxTaskExecutionContext\":{\n" +
" \"dataSourceId\":0,\n" +
" \"sourcetype\":0,\n" +
" \"sourceConnectionParams\":null,\n" +
" \"dataTargetId\":0,\n" +
" \"targetType\":0,\n" +
" \"targetConnectionParams\":null\n" +
" },\n" +
" \"dependenceTaskExecutionContext\":null,\n" +
" \"sqoopTaskExecutionContext\":{\n" +
" \"dataSourceId\":0,\n" +
" \"sourcetype\":0,\n" +
" \"sourceConnectionParams\":null,\n" +
" \"dataTargetId\":0,\n" +
" \"targetType\":0,\n" +
" \"targetConnectionParams\":null\n" +
" },\n" +
" \"procedureTaskExecutionContext\":{\n" +
" \"connectionParams\":null\n" +
" }\n" +
"}" ;
TaskExecutionContext taskExecutionContext = JSONUtils.parseObject(contextJson, TaskExecutionContext.class);
assertTrue(taskExecutionContext != null);
}
}
```
error info :
```
Connected to the target VM, address: '127.0.0.1:53429', transport: 'socket'
19:43:31.405 [main] ERROR org.apache.dolphinscheduler.common.utils.JSONUtils - parse object exception!
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot find a (Map) Key deserializer for type [simple type, class org.apache.dolphinscheduler.dao.entity.UdfFunc]
at [Source: (String)"{
"taskInstanceId":2,
"taskName":"SQL-QUERY",
"startTime":"2020-07-18 19:18:58",
"taskType":"SQL",
"host":null,
"executePath":"/tmp/dolphinscheduler/exec/process/2/17/2/2",
"logPath":null,
"taskJson":"{"id":"tasks-5736","name":"SQL-QUERY","desc":null,"type":"SQL","runFlag":"NORMAL","loc":null,"maxRetryTimes":0,"retryInterval":1,"params":{"type":"MYSQL","datasource":3,"sql":"SELECT * FROM person","udfs":"","sqlType":"0","title":"SQL-QUERY","receivers":"zhangboyi_mx"[truncated 1787 chars]; line: 1, column: 1]
at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:67)
at com.fasterxml.jackson.databind.DeserializationContext.reportBadDefinition(DeserializationContext.java:1452)
at com.fasterxml.jackson.databind.deser.DeserializerCache._handleUnknownKeyDeserializer(DeserializerCache.java:599)
at com.fasterxml.jackson.databind.deser.DeserializerCache.findKeyDeserializer(DeserializerCache.java:168)
at com.fasterxml.jackson.databind.DeserializationContext.findKeyDeserializer(DeserializationContext.java:500)
at com.fasterxml.jackson.databind.deser.std.MapDeserializer.createContextual(MapDeserializer.java:248)
at com.fasterxml.jackson.databind.DeserializationContext.handlePrimaryContextualization(DeserializationContext.java:651)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.resolve(BeanDeserializerBase.java:484)
at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:293)
at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:244)
at com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142)
at com.fasterxml.jackson.databind.DeserializationContext.findNonContextualValueDeserializer(DeserializationContext.java:467)
at com.fasterxml.jackson.databind.deser.BeanDeserializerBase.resolve(BeanDeserializerBase.java:473)
at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:293)
at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:244)
at com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142)
at com.fasterxml.jackson.databind.DeserializationContext.findRootValueDeserializer(DeserializationContext.java:477)
at com.fasterxml.jackson.databind.ObjectMapper._findRootDeserializer(ObjectMapper.java:4190)
at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4009)
at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3004)
at org.apache.dolphinscheduler.common.utils.JSONUtils.parseObject(JSONUtils.java:108)
at org.apache.dolphinscheduler.server.worker.processor.TaskExecuteProcessorTest.testJson(TaskExecuteProcessorTest.java:71)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
Disconnected from the target VM, address: '127.0.0.1:53429', transport: 'socket'
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertTrue(Assert.java:52)
at org.apache.dolphinscheduler.server.worker.processor.TaskExecuteProcessorTest.testJson(TaskExecuteProcessorTest.java:73)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:230)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:58)
```
| https://github.com/apache/dolphinscheduler/issues/3240 | https://github.com/apache/dolphinscheduler/pull/3245 | 252abbdaed4a120b0bc5c23da3e956e3d429a7a1 | 6f2667bf1aab2715cfd734a5a694d2b2fd0adcc9 | "2020-07-18T11:39:43Z" | java | "2020-07-21T10:54:07Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,238 | ["docker/docker-swarm/docker-compose.yml"] | [Bug][Resource Center] Can not create folder in docker with standalone mode | Creating a folder in the Resource Center failed.
1. build docker images by default Dockerfile
2. run docker with args ALL
3. open resource center, and create a folder
4. See error
**Which version of Dolphin Scheduler:**
-[1.3.1]
**Additional context**
The error info in logs is : NulPointer Error in createDirecortry(ResourceService.java:484)
It seems to be a HDFS error. but in DOC, the local fs is supported.
And then,I modify the common config file, change the storage.type from NONE to HDFS, but still failed.
i want to evaluate dolphinscheduler quickly, but it's not very easy -_-b
Please consider being able to quickly evaluate the software through docker.
| https://github.com/apache/dolphinscheduler/issues/3238 | https://github.com/apache/dolphinscheduler/pull/3772 | 973cbf8d86df6a0895a5c19cfc69c38b89853850 | b2e78cbf9cea99bbeb5656b071a9db8b025be363 | "2020-07-18T09:25:05Z" | java | "2020-09-21T03:36:19Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,233 | ["dolphinscheduler-api/pom.xml", "dolphinscheduler-dist/release-docs/LICENSE", "dolphinscheduler-dist/release-docs/licenses/LICENSE-ant-1.6.5.txt", "dolphinscheduler-dist/release-docs/licenses/LICENSE-core-3.1.1.txt", "dolphinscheduler-dist/release-docs/licenses/LICENSE-jsp-api-2.1-6.1.14.txt", "pom.xml", "tools/dependencies/known-dependencies.txt"] | [Bug][api-server] ClassCastException: AppClassLoader cannot be cast to class java.net.URLClassLoader | *For better global communication, please give priority to using English description, thx! *
**Which version of Dolphin Scheduler:**
1.3.1
**Describe the bug**
Just started the api-server, logs show as follows:
```
[WARN] 2020-07-17 10:17:17.231 org.eclipse.jetty.server.handler.ContextHandler.application:[2355] - unavailable
java.lang.ClassCastException: class jdk.internal.loader.ClassLoaders$AppClassLoader cannot be cast to class java.net.URLClassLoader (jdk.internal.loader.ClassLoaders$AppClassLoader and java.net.URLClassLoader are in module java.base of loader 'bootstrap')
at org.apache.jasper.compiler.JspRuntimeContext.<init>(JspRuntimeContext.java:174)
at org.apache.jasper.servlet.JspServlet.init(JspServlet.java:150)
at org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:672)
at org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:429)
at org.eclipse.jetty.servlet.ServletHandler.lambda$initialize$0(ServletHandler.java:750)
at java.base/java.util.stream.SortedOps$SizedRefSortingSink.end(SortedOps.java:357)
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:485)
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
at java.base/java.util.stream.StreamSpliterators$WrappingSpliterator.forEachRemaining(StreamSpliterators.java:312)
at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:735)
at java.base/java.util.stream.Streams$ConcatSpliterator.forEachRemaining(Streams.java:734)
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:658)
at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:744)
at org.springframework.boot.web.embedded.jetty.JettyEmbeddedWebAppContext$JettyEmbeddedServletHandler.deferredInitialize(JettyEmbeddedWebAppContext.java:46)
at org.springframework.boot.web.embedded.jetty.JettyEmbeddedWebAppContext.deferredInitialize(JettyEmbeddedWebAppContext.java:36)
at org.springframework.boot.web.embedded.jetty.JettyWebServer.handleDeferredInitialize(JettyWebServer.java:221)
at org.springframework.boot.web.embedded.jetty.JettyWebServer.start(JettyWebServer.java:142)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.startWebServer(ServletWebServerApplicationContext.java:311)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.finishRefresh(ServletWebServerApplicationContext.java:164)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:552)
at org.springframework.boot.web.servlet.context.ServletWebServerApplicationContext.refresh(ServletWebServerApplicationContext.java:142)
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:775)
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:397)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:316)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1260)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1248)
at org.apache.dolphinscheduler.api.ApiApplicationServer.main(ApiApplicationServer.java:36)
```
I found [an explaination on stackoverflow][1]. It shows that JDK 9 has a breaking change here.
[1]: https://stackoverflow.com/questions/39739075/hive-shell-not-loading/41637409#41637409
**Requirement or improvement**
Please fix this to make DS compatible with modern JDK. Thanks! | https://github.com/apache/dolphinscheduler/issues/3233 | https://github.com/apache/dolphinscheduler/pull/4312 | 9c226435e377e055c64c4c5586a2fcd426ca61af | b8dc4357270ef4610237e2bb498fe604153c2a0f | "2020-07-17T17:30:23Z" | java | "2021-01-05T02:02:16Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,187 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java"] | [BUG] Heartbeat thread pool does not shutdown when MasterRegistry unRegistry | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
look at the method of MasterRegistry
```java
public void unRegistry() {
String address = getLocalAddress();
String localNodePath = getMasterPath();
zookeeperRegistryCenter.getZookeeperCachedOperator().remove(localNodePath);
logger.info("master node : {} unRegistry to ZK.", address);
}
```
The method, which is invoke when close the MasterServer, does not shutdown the Heartbeat thread pool. | https://github.com/apache/dolphinscheduler/issues/3187 | https://github.com/apache/dolphinscheduler/pull/3188 | 98fdba6740abcb8dd30bc08d6ff39793dd9dd598 | 88f9bed726d479d4be4a46fb599161d5e61f496f | "2020-07-10T17:28:52Z" | java | "2020-07-13T06:27:38Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,181 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java"] | [BUG] get http code 400 bad request with AWS S3 as resource storage type | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
when you use AWS S3 as the resource storage backend you will get a error like:
``` log
Status Code: 400, AWS Service: Amazon S3, AWS Request ID: xxxxxxx, AWS Error Code: null, AWS Error Message: Bad Request
```
**To Reproduce**
Steps to reproduce the behavior, for example:
just set `resource.storage.type=S3` in common.properties and also keep other configuration correct.
**Expected behavior**
the resource centre work fine.
**Screenshots**
when you try to upload a file at resource centre, you will get a error.
**Which version of Dolphin Scheduler:**
-[1.3.1-release]
**Additional context**
it is because of the version of AWS S3 encryption method.
**Requirement or improvement**
I will make a PR for this later.
| https://github.com/apache/dolphinscheduler/issues/3181 | https://github.com/apache/dolphinscheduler/pull/3182 | 1e7582e910c23a42bb4e92cd64fde4df7cbf6b34 | dcdd7dedd06454ed468eae86881b75177261c9e2 | "2020-07-10T11:30:13Z" | java | "2020-07-11T00:56:38Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,179 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/startingParam/index.vue", "dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/start.vue", "dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/timing.vue"] | [BUG] cache bug |
**Describe the bug**
![image](https://user-images.githubusercontent.com/7700151/87138506-1a18ae80-c2d1-11ea-8a75-98af77b07589.png)
When I go to use it
![image](https://user-images.githubusercontent.com/7700151/87138427-fd7c7680-c2d0-11ea-971d-02800505ba9b.png)
| https://github.com/apache/dolphinscheduler/issues/3179 | https://github.com/apache/dolphinscheduler/pull/3200 | a7aa58e6ca258c817ec53d8ae27743e4904189c7 | 3aa34bc72363eab368ade91b6e5be77b67897b02 | "2020-07-10T09:17:26Z" | java | "2020-07-16T06:56:53Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,176 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/CommonUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/HadoopUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java"] | [BUG] optimize #3165 Gets the value of this property “resource.storage.type”, Comparison with enumerated types | By looking at the ResourcesService code, I found a potential problem.
Enumeration type comparisons are used in both classes :HadoopUtils.java ,CommonUtils.java
I don't think this [submission](https://github.com/apache/incubator-dolphinscheduler/pull/3166) is perfect
All comparisons of ResUploadType need to be optimized.
I'm going to modify this part
中文:
通过阅读ResourcesService代码,发现了潜在隐患。
在HadoopUtils和CommonUtils,资源中心类型,都是通过枚举类型比较。
所以感觉到[submission](https://github.com/apache/incubator-dolphinscheduler/pull/3166) 这个提交是不完备的。
需要优化所有的ResUploadType类型比较部分的代码。
| https://github.com/apache/dolphinscheduler/issues/3176 | https://github.com/apache/dolphinscheduler/pull/3178 | 1eb8fb6db33af4b644492a9fb0b0348d7de14407 | 1e7582e910c23a42bb4e92cd64fde4df7cbf6b34 | "2020-07-10T06:05:07Z" | java | "2020-07-10T07:21:42Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,165 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/PropertyUtils.java"] | config resource.storage.type=hdfs throw exception need config resource.storage.type=HDFS | when i config common.properties ,
resource.storage.type=hdfs
will throw exception
![image](https://user-images.githubusercontent.com/59079269/86872565-3cfb6500-c10f-11ea-802b-21fdf1003db7.png)
because Enumerated type comparisons do not ignore case。 | https://github.com/apache/dolphinscheduler/issues/3165 | https://github.com/apache/dolphinscheduler/pull/3166 | ae902e2308b60f57010918bbce67703def10a02f | a23a3e2d1254acf1d6c194f4996824e3f290cae1 | "2020-07-08T03:37:44Z" | java | "2020-07-09T10:28:04Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,157 | ["dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/remote/NettyRemotingServer.java"] | [BUG] netty server may start multiple times if multiple threads execute the start method | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
look at the code of NettyRemotingServer
```java
public void start(){
if(this.isStarted.get()){
return;
}
this.serverBootstrap
.group(this.bossGroup, this.workGroup)
.channel(NioServerSocketChannel.class)
.option(ChannelOption.SO_REUSEADDR, true)
.option(ChannelOption.SO_BACKLOG, serverConfig.getSoBacklog())
.childOption(ChannelOption.SO_KEEPALIVE, serverConfig.isSoKeepalive())
.childOption(ChannelOption.TCP_NODELAY, serverConfig.isTcpNoDelay())
.childOption(ChannelOption.SO_SNDBUF, serverConfig.getSendBufferSize())
.childOption(ChannelOption.SO_RCVBUF, serverConfig.getReceiveBufferSize())
.childHandler(new ChannelInitializer<NioSocketChannel>() {
@Override
protected void initChannel(NioSocketChannel ch) throws Exception {
initNettyChannel(ch);
}
});
ChannelFuture future;
try {
future = serverBootstrap.bind(serverConfig.getListenPort()).sync();
} catch (Exception e) {
logger.error("NettyRemotingServer bind fail {}, exit",e.getMessage(), e);
throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort()));
}
if (future.isSuccess()) {
logger.info("NettyRemotingServer bind success at port : {}", serverConfig.getListenPort());
} else if (future.cause() != null) {
throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort()), future.cause());
} else {
throw new RuntimeException(String.format("NettyRemotingServer bind %s fail", serverConfig.getListenPort()));
}
//
isStarted.compareAndSet(false, true);
}
```
If multiple threads execute the method at a time, it may start the netty server multiple times.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Expected behavior**
A clear and concise description of what you expected to happen.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-[1.1.0-preview]
**Additional context**
Add any other context about the problem here.
**Requirement or improvement
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/3157 | https://github.com/apache/dolphinscheduler/pull/3158 | d4d6aded1184b803557f444c42253d02887995b9 | bf3cc0d00ef27eb0523b4542e5905256e369b068 | "2020-07-06T12:12:29Z" | java | "2020-07-07T10:45:20Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,140 | ["dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/ZKServer.java", "dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/zk/ZKServerTest.java"] | [BUG] Embed zookeeper server 'ZKServer' has deadlock problem | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
look at the code snippet
```java
private static synchronized void startLocalZkServer(final int port, final String dataDirPath,final int tickTime,String maxClientCnxns) {
if (zkServer != null) {
throw new RuntimeException("Zookeeper server is already started!");
}
zkServer = new PublicZooKeeperServerMain();
logger.info("Zookeeper data path : {} ", dataDirPath);
dataDir = dataDirPath;
final String[] args = new String[]{Integer.toString(port), dataDirPath, Integer.toString(tickTime), maxClientCnxns};
try {
logger.info("Zookeeper server started ");
isStarted.compareAndSet(false, true);
zkServer.initializeAndRun(args);
} catch (QuorumPeerConfig.ConfigException e) {
logger.warn("Caught exception while starting ZK", e);
} catch (IOException e) {
logger.warn("Caught exception while starting ZK", e);
}
}
```
The above start method will acquire the lock of the ZKServer class. But the line "zkServer.initializeAndRun(args);" will block until the application exit. So it will never release the lock.
```java
private static synchronized void stopLocalZkServer(final boolean deleteDataDir) {
// 省略
}
```
The above stop method try to acquire the lock of the ZKServer class, but it will never succeed.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
**Expected behavior**
A clear and concise description of what you expected to happen.
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-[1.1.0-preview]
**Additional context**
Add any other context about the problem here.
**Requirement or improvement
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/3140 | https://github.com/apache/dolphinscheduler/pull/3141 | 6f9970b189d71d043e79200a70a95f2f33ad10f4 | 753ed58fb9f15f85240918fe6457cf9015ee5101 | "2020-07-05T15:26:02Z" | java | "2020-07-13T10:52:33Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,124 | ["docker/build/hooks/build.bat"] | [BUG] a error when build a docker image | **Describe the bug**
A error throw and then build break when I use `.\docker\build\hooks\build.bat`.
**Screenshots**
![image](https://user-images.githubusercontent.com/4559753/86505045-93586300-bdf2-11ea-9a5a-23113408e1aa.png)
**Which version of Dolphin Scheduler:**
-1.3.1-release
**Requirement or improvement
- Windows 10 Pro
| https://github.com/apache/dolphinscheduler/issues/3124 | https://github.com/apache/dolphinscheduler/pull/3765 | 5c8171e3977b46e09e8d70119f00ecd0d60ecb05 | 09bdd99004ee4f311997a82974273569f5a9d678 | "2020-07-04T04:45:06Z" | java | "2020-09-22T02:04:26Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,085 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/dragZoom.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/jsPlumbHandle.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/util.js"] | [BUG] after zoom or drag the dag view, cant plcae node correctly and may be disappear | **Describe the bug**
After zoom or drag the dag view, cant plcae node correctly and may be disappear
**To Reproduce**
1. Go to 'project detail dag'
2. Scroll middle mouse button, zoom nodes
3. Drag new node into contaiment. (close to sidebar )
4. See error, the new node diappear, or it cant place what we want.
**Expected behavior**
When we drag new node into contaiment, it should not disappear. Because we do the correct thing, but something wrong happen.
**Screenshots**
![no zoom](https://user-images.githubusercontent.com/40662353/86087052-d0acb000-bad5-11ea-827e-de9316d989a1.png)
![after zoom](https://user-images.githubusercontent.com/40662353/86087169-1a959600-bad6-11ea-858a-b9fc00cc74f0.png)
**Which version of Dolphin Scheduler:**
-[1.2.0 to latest version ]
**Additional context**
After zooming (or drag #canvas element), the area of the canvas and the outer area do not fit, causing the drag to fail.
I try to fix this problem. There has two ways.
1. use jsplumb nativie method to support zoom.
2. modify dragZoom.js code, change the zoom beahavior.
I choose 2, I think this way lead to increased code complexity. Any suggetions? Should I create a PR?
| https://github.com/apache/dolphinscheduler/issues/3085 | https://github.com/apache/dolphinscheduler/pull/3103 | b0a7bb4d9c1fbeaa96b3aff8d2ab928a4c6c6c15 | 631cc6ea1fbc95e55597982f3c5a23d1f3751327 | "2020-06-30T05:34:19Z" | java | "2020-07-02T06:19:04Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,077 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/udp/udp.vue"] | [BUG] repeated task name in one flow | first add two different tasks,then rename one and keep both has a some name ,you will find you can save the flow with same name tasks. | https://github.com/apache/dolphinscheduler/issues/3077 | https://github.com/apache/dolphinscheduler/pull/3376 | 26184de905b9e1a83b0e27e8e50e335f12131fdf | 555880e6e32ab5235f1947fe036f43cef54e50c4 | "2020-06-29T11:37:26Z" | java | "2020-08-25T03:18:36Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,058 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/jsPlumbHandle.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/util.js"] | [BUG] 1.3.0 branch The task running order in the process instance does not follow the topological order in the process definition | 1. process definition
![1593309494(1)](https://user-images.githubusercontent.com/9334358/85935770-d9ab4f00-b926-11ea-9f69-52a9e11ad699.jpg)
2. task instance order in database
![72423ea1aafbee8b832e4798046dff7](https://user-images.githubusercontent.com/9334358/85935784-fa73a480-b926-11ea-93a2-aa89f2718f29.png)
3. task instance order in web ui
![image](https://user-images.githubusercontent.com/9334358/85935791-0b241a80-b927-11ea-9288-a61e66d0486b.png)
4.task instance order in process instance
![image](https://user-images.githubusercontent.com/9334358/85935795-1aa36380-b927-11ea-9532-99462048e24c.png)
The task running order in the process instance does not follow the topological order in the process definition, Why?
| https://github.com/apache/dolphinscheduler/issues/3058 | https://github.com/apache/dolphinscheduler/pull/3464 | 46f058698170fff573bbd02af74762ded639769c | e2553e33d78f438f8519f6e3dce1f555b002db65 | "2020-06-28T02:07:54Z" | java | "2020-08-11T10:51:12Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 3,018 | ["dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/list.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [BUG] i18n incomplete | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
In User page, the user type is not in i18n;
**To Reproduce**
Steps to reproduce the behavior, for example:
1. In file '\dolphinscheduler-ui\src\js\conf\home\pages\security\pages\users\_source\list.vue'
2. In line 29
3. the '用户类型' should be '{{$t('User Type')}}'
4. and the i18n file should be update
**Expected behavior**
modify the page without i18n
**Screenshots**
None
**Which version of Dolphin Scheduler:**
-[1.3.0]
**Additional context**
None
**Requirement or improvement
None
| https://github.com/apache/dolphinscheduler/issues/3018 | https://github.com/apache/dolphinscheduler/pull/3022 | 4aa1826718a75d9fc7ac948d871732a09abc8b8d | 6e0b464531d322c2ff60470d3ed63d025d8c970f | "2020-06-19T03:43:13Z" | java | "2020-06-20T14:22:55Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,923 | ["dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSource.java", "dolphinscheduler-dao/src/test/java/org/apache/dolphinscheduler/dao/datasource/HiveDataSourceTest.java", "pom.xml"] | [BUG] Hive JDBC connection parameter ignored | **Describe the bug**
The jdbc connection parameter of Hive datasource, should append after the question mark when building jdbc url, like `jdbc:hive2://host:port/default?mapred.job.queue.name=root.users.a`. But actually, it append after the semicolon, so the result is `jdbc:hive2://host:port/default;mapred.job.queue.name=root.users.a`, which make the parameter being ignored
![image](https://user-images.githubusercontent.com/16650282/83969066-3efbb980-a900-11ea-8c83-ffa899d7a65b.png)
For testing, I set the parameter in this way `{"?mapred.job.queue.name":"root.user.a"}`, and now it can be set correctly
**Which version of Dolphin Scheduler:**
- [1.2.1-release]
| https://github.com/apache/dolphinscheduler/issues/2923 | https://github.com/apache/dolphinscheduler/pull/3194 | 6d43c21d80a3b210a7e01df9fa73d4f076698a58 | 98fdba6740abcb8dd30bc08d6ff39793dd9dd598 | "2020-06-07T12:52:13Z" | java | "2020-07-13T05:58:01Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,910 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/dispatch/host/LowerWeightHostManager.java", "sql/h2.mv.db"] | [BUG] master server will show exception for some time when master server restart, it's just dispatching task | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
[ERROR] 2020-06-06 15:46:22.683 org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer:[152] - dispatch error
org.apache.dolphinscheduler.server.master.dispatch.exceptions.ExecuteException: fail to execute : Command [type=TASK_EXECUTE_REQUEST, opaque=1, bodyLen=1619] due to no suitable worker , current task need to default worker group execute
at org.apache.dolphinscheduler.server.master.dispatch.ExecutorDispatcher.dispatch(ExecutorDispatcher.java:87)
at org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer.dispatch(TaskPriorityQueueConsumer.java:149)
at org.apache.dolphinscheduler.server.master.consumer.TaskPriorityQueueConsumer.run(TaskPriorityQueueConsumer.java:118)
**To Reproduce**
1、worker server runs normally, click `start workflow` ,
2、then restart master server , master server runtime log will show the following exception for some time(about 30 seconds), then master will go works normally
**Which version of Dolphin Scheduler:**
-[ dev-1.3.0 ]
| https://github.com/apache/dolphinscheduler/issues/2910 | https://github.com/apache/dolphinscheduler/pull/2913 | 0de8e589651396925f66549b75e57b9673669291 | 5c9b080ab85ffc458557ebcbb5e8bf30a7c40ed0 | "2020-06-06T07:57:47Z" | java | "2020-06-06T10:24:26Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,892 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java"] | [BUG] When editing user information, clear the phone number, the database table t_ds_user.phone is not cleared |
![image](https://user-images.githubusercontent.com/55787491/83727354-7f94d200-a677-11ea-9937-70d96123137e.png)
![image](https://user-images.githubusercontent.com/55787491/83727493-ba970580-a677-11ea-8dd4-6e1a40201d05.png)
**Which version of Dolphin Scheduler:**
-[dev-1.3.0]
| https://github.com/apache/dolphinscheduler/issues/2892 | https://github.com/apache/dolphinscheduler/pull/2898 | 4441d91dcf178653e55b94fe564c8c9907e897fa | ae9afcf77a930d10d1d61aa23172b831f1a41cdd | "2020-06-04T07:26:35Z" | java | "2020-06-04T09:26:59Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,860 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/UsersService.java"] | [BUG] When a user has a resource directory tree, update the user's tenant to report an error |
![image](https://user-images.githubusercontent.com/55787491/83390197-03ef1700-a424-11ea-8894-674e758cd92d.png)
![image](https://user-images.githubusercontent.com/55787491/83390230-10736f80-a424-11ea-8fd7-c7b9acf27a20.png)
**Which version of Dolphin Scheduler:**
-[dev_1.3.0]
**Additional context**
Add any other context about the problem here.
**Requirement or improvement
- Please describe about your requirements or improvement suggestions.
| https://github.com/apache/dolphinscheduler/issues/2860 | https://github.com/apache/dolphinscheduler/pull/2876 | 6723454df9c7d85d3f034d2c13a080db4c130fc1 | 31dca43cdbaec861b2bfc5dc7407f50424216e3c | "2020-06-01T08:22:32Z" | java | "2020-06-02T10:33:06Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,762 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/config/MasterConfig.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumer.java", "dolphinscheduler-server/src/main/resources/master.properties", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/consumer/TaskPriorityQueueConsumerTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/runner/MasterTaskExecThreadTest.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/registry/DependencyConfig.java"] | [BUG]the master would be blocked when worker group not exists | **Is your feature request related to a problem? Please describe.**
i create a task with a special worker group,
master would be blocked when the worker group does not exists,
In this case, other tasks would not run anymore.
version:
[dev-1.3.0] | https://github.com/apache/dolphinscheduler/issues/2762 | https://github.com/apache/dolphinscheduler/pull/2764 | 7d2441f63468fb4c9e340f0be0bd6844923a9743 | 7a05c007b45ea742e3ed1a7558c1a641515c140c | "2020-05-20T02:17:55Z" | java | "2020-05-21T02:34:14Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,739 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ParameterUtils.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java"] | [BUG] SQLTask replace the ${} of the SQL statement to "?" does not work | **Describe the bug**
In the SqlTask
the function ParameterUtils.replaceScheduleTime(sql, taskExecutionContext.getScheduleTime(), paramsMap) replaces all $ {} to real value, so the function setSqlParamsMap(sql, rgex, sqlParamsMap, paramsMap); does not work
**Screenshots**
![image](https://user-images.githubusercontent.com/10829956/82187951-bb156980-991f-11ea-9f69-bf978ae83429.png)
**Which version of Dolphin Scheduler:**
-[dev-1.3.0]
| https://github.com/apache/dolphinscheduler/issues/2739 | https://github.com/apache/dolphinscheduler/pull/2741 | cfd83235a29ec9e19f3c87a27e7d77edf3381c63 | 6d0375e46d07f386125a3c6e091e605a515df03d | "2020-05-18T07:56:57Z" | java | "2020-05-21T08:09:36Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,735 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/ResInfo.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/registry/MasterRegistry.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/registry/HeartBeatTask.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/registry/WorkerRegistry.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java", "dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/master.vue", "dolphinscheduler-ui/src/js/conf/home/pages/monitor/pages/servers/worker.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [BUG]The IP and process pid of the master and worker in the monitoring center are not displayed |
![image](https://user-images.githubusercontent.com/55787491/82179785-c06bb780-9911-11ea-996a-ec3aad68bf41.png)
![image](https://user-images.githubusercontent.com/55787491/82179769-b5188c00-9911-11ea-8e31-699b85b3a304.png)
**Which version of Dolphin Scheduler:**
-[dev_1.3.0]
| https://github.com/apache/dolphinscheduler/issues/2735 | https://github.com/apache/dolphinscheduler/pull/2770 | 3d857bba925348f4b92b9ba857c37fbca28549dd | 396b1716e4e9b0f55f3686ba8e0283555c65c085 | "2020-05-18T06:14:37Z" | java | "2020-05-22T03:20:54Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,715 | ["dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/UsersServiceTest.java"] | compile error on UsersServiceTest |
**Describe the bug**
compile error on UsersServiceTest.java
**To Reproduce**
mvn package
**Expected behavior**
remove unused import
**Screenshots**
![image](https://user-images.githubusercontent.com/11856424/81902918-80e05b00-95f3-11ea-854b-f16cf271177b.png)
**Which version of Dolphin Scheduler:**
-[dev-1.3.0]
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2715 | https://github.com/apache/dolphinscheduler/pull/2718 | 11c4c583286d913c17eb8efff029d93d89f98b25 | 9fd728908fd41b8aecc9565687060f96f413936a | "2020-05-14T07:15:13Z" | java | "2020-06-14T02:27:13Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,638 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/DataSourceService.java"] | Improve the security of datasource management | **Is your feature request related to a problem? Please describe.**
Company database account management is relatively strict. We found that when the data source management is updated, the original password is actually brought out.
(公司数据库账号管理比较严格,我们发现目前数据源管理更新得时候实际上是把原始密码给带出来了。)
**Describe the solution you'd like**
The datasources / update-ui interface should not take out the password. The datasources / updateDataSource interface does not update this field without passing the password. You can call the query one more time when the server is updated.
(datasources/update-ui 接口不要将密码带出去,datasources/updateDataSource 接口不传 密码就不更新该字段,服务端更新时可以先多调用一次查询。)
| https://github.com/apache/dolphinscheduler/issues/2638 | https://github.com/apache/dolphinscheduler/pull/2844 | fbb8ff438ad0c0db1bfc78d33bbc73b2c7d40683 | 1c153454423f4b967f3fcd8fb906a4626799872f | "2020-05-08T08:42:20Z" | java | "2020-05-30T07:03:10Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,634 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"] | Process shows success,when the task of the process is killed in the terminal | 重现步骤:
1、有两个工作流AA和BB,BB依赖AA。
2、AA中有test1和test2任务,test2任务依赖test1。
3、BB中有dependent和test3任务,dependent配置AA的test2,test3依赖dependent。
4、现在手工运行AA,(test1任务可以配置shell,shell中运行一个test1.sh文件,该文件中可以写个sleep 60s),在执行worker的终端kill掉该任务(这种情况是手工kill,实际生产中服务器压力大时很有可能被其他服务kill掉)。
5、此时显示工作流AA运行成功,AA中test1任务kill状态,test2任务没有运行。
6、手工运行BB,可以看到BB中dependent和test3任务都运行成功。
正确的场景是AA中test1被kill后,AA应该是失败状态而不是成功状态,BB因dependent失败而失败
--------------------------------------------------------------------------------------
Reproduction steps:
1. There are two workflows AA and BB, and BB depends on AA.
2. There are test1 and test2 tasks in AA, and test2 tasks depend on test1.
3. There are DEPENDENCT and test3 tasks in BB. DEPENDENCT configures test2 of AA, and test3 depends on the DEPENDENCT.
4. Now run AA manually (test1 task can configure the shell, and a test1.sh file can be run in the shell, and a sleep 60s can be written in the file). Kill the task at the terminal executing the worker (in this case, kill manually. In actual production, when the server is under great pressure, it is likely to be killed by other services).
5. At this time, the workflow AA runs successfully, the test1 task in AA is in kill status, and the test2 task is not running.
6. Run BB manually, and you can see that the DEPENDENCT and test3 tasks in BB run successfully.
I think the correct scenario is that after test1 in AA is killed, AA should be in failure state instead of success state. BB fails due to the DEPENDENCT failure | https://github.com/apache/dolphinscheduler/issues/2634 | https://github.com/apache/dolphinscheduler/pull/2731 | 9ffcd82447cd355955d110fe19afb33f465f9d7e | a9da86abb4545b1ac8fdc5cdd05e85bdcdffa9c6 | "2020-05-08T06:20:02Z" | java | "2020-05-18T10:27:16Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,619 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProjectService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/controller/ProjectControllerTest.java"] | [BUG] /dolphinscheduler/projects/create doesn't return project ID when create successfuly |
**Describe the bug**
V1.2.0, when invoke /dolphinscheduler/projects/create, it doesn't return project ID when create successfuly just return
{
"code": 0,
"msg": "success",
"data": null
}
**Expected behavior**
it should return project ID, otherwise, how can I build relationship between dolphin and my system.
**Which version of Dolphin Scheduler:**
-[1.2.0]
**Additional context**
Add any other context about the problem here.
**Requirement or improvement
- Please fix this or tell me how to get project ID for newly created project.
| https://github.com/apache/dolphinscheduler/issues/2619 | https://github.com/apache/dolphinscheduler/pull/2804 | e89f543f04872b2b7d8d3c5cd94e68cd4ddaab7e | fbb8ff438ad0c0db1bfc78d33bbc73b2c7d40683 | "2020-05-07T08:17:58Z" | java | "2020-05-30T04:45:39Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,603 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java"] | [BUG] code annotation error | incubator-dolphinscheduler-dev/dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/WorkerServer.java
Source code:
/**
* master server startup
*
* master server not use web service
* @param args arguments
*/
public static void main(String[] args) {
Thread.currentThread().setName(Constants.THREAD_NAME_WORKER_SERVER);
new SpringApplicationBuilder(WorkerServer.class).web(WebApplicationType.NONE).run(args);
}
The master in the annotation on lines 74 and 76 should be changed to worker.
| https://github.com/apache/dolphinscheduler/issues/2603 | https://github.com/apache/dolphinscheduler/pull/2614 | 8e080ef6085e285480e906ee8dee301e3790bc02 | 8c8e128d18b2a1e189b05554a8c011749c1408b7 | "2020-05-06T07:20:42Z" | java | "2020-05-08T07:23:31Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,598 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/enums/Status.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java"] | [BUG] After renaming the file, downloading the file gives an error | 1. create file is test_1.sh
2. The file is renamed to test_1.txt, and the file name displayed on the page is "test_1.txt.sh"
3. Download file, prompt "error downloading resource file"
4. Check the hdfs resource file is "test_1.txt"
![image](https://user-images.githubusercontent.com/55787491/81133105-3d4a7900-8f83-11ea-9ce6-d36fa2f38a43.png)
![image](https://user-images.githubusercontent.com/55787491/81132928-a7aee980-8f82-11ea-8b0a-e3ed7231e560.png)
![image](https://user-images.githubusercontent.com/55787491/81133119-48050e00-8f83-11ea-84a5-83bc3f9f84d3.png)
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2598 | https://github.com/apache/dolphinscheduler/pull/2732 | 63ce143be5fd76ea08f9fcf73e7720cb1be99297 | 60f8eb25fa69fa39cd17404b9eb66376c174b9c3 | "2020-05-06T02:17:35Z" | java | "2020-05-18T09:56:41Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,584 | ["docker/build/README.md", "docker/build/README_zh_CN.md", "docker/build/conf/dolphinscheduler/worker.properties.tpl", "docker/docker-swarm/docker-compose.yml", "docker/docker-swarm/docker-stack.yml", "docker/kubernetes/dolphinscheduler/README.md", "dolphinscheduler-server/src/main/resources/worker.properties"] | [Feature] 建议k8s部署的时候默认数据库是MySQL,降低使用门槛 | 建议k8s部署的时候默认数据库是MySQL,降低使用门槛。
目前随着Tidb等NewSQL数据库的流行,NewSQL会成为技术中台的首选数据库,而Tidb作为一个非常火的项目是搭建技术中台的首选数据库,Tidb兼容MySQL协议而非pg协议,所以incubator-dolphinscheduler的数据直接建在Tidb上是非常合适的 | https://github.com/apache/dolphinscheduler/issues/2584 | https://github.com/apache/dolphinscheduler/pull/4875 | 139211f3ddf9e30fb058c659fd467b18a95d0dbe | bfc5d1e4ba08cc19059bb40293bb0777b3d42377 | "2020-04-30T02:53:24Z" | java | "2021-02-27T14:44:55Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,581 | ["dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"] | [BUG] When the process involves sub-processes, the complement operation will only take the start time, and will repeat the number of days to perform the complement | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
When the process involves sub-processes, the complement operation will only take the start time, and will repeat the number of days to perform the complement.
**To Reproduce**
Steps to reproduce the behavior, for example:
1. Create a simple sub-process, such as a shell
2. Create another main process and associate sub-processes
3. For complement operation, you can also make up only two days
The specific operation is as follows:
1. Create subprocess,
![image](https://user-images.githubusercontent.com/10054719/80662237-5e165880-8ac3-11ea-9e47-ea97af1179ab.png)
2. Save subprocess and setting variables
![image](https://user-images.githubusercontent.com/10054719/80662384-b6e5f100-8ac3-11ea-84f5-a307acc79f88.png)
3. Create the main process and create sub node as in main process
![image](https://user-images.githubusercontent.com/10054719/80662453-d715b000-8ac3-11ea-8186-b7a92a709c79.png)
![image](https://user-images.githubusercontent.com/10054719/80662492-f0b6f780-8ac3-11ea-9c0c-ed628b82772c.png)
4. Save main process and setting variables
![image](https://user-images.githubusercontent.com/10054719/80662523-07f5e500-8ac4-11ea-8b15-8df097cc5c76.png)
5. As follow.
![image](https://user-images.githubusercontent.com/10054719/80662545-193ef180-8ac4-11ea-8343-802808ad278f.png)
6. Then complement
![image](https://user-images.githubusercontent.com/10054719/80662594-3b387400-8ac4-11ea-96b1-75fa364ca167.png)
7. The result is as follows, the date printed is only the start date
![image](https://user-images.githubusercontent.com/10054719/80662665-67ec8b80-8ac4-11ea-9ae2-d082087efe6b.png)
![image](https://user-images.githubusercontent.com/10054719/80662670-6d49d600-8ac4-11ea-8487-608327a30654.png)
![image](https://user-images.githubusercontent.com/10054719/80662674-70dd5d00-8ac4-11ea-914d-096c12cbfb9c.png)
8. The timing of the main process is correct
![image](https://user-images.githubusercontent.com/10054719/80662741-9bc7b100-8ac4-11ea-9d4d-e05c54ca5a86.png)
**Which version of Dolphin Scheduler:**
-[1.2.1]
- Stand-alone deployment
| https://github.com/apache/dolphinscheduler/issues/2581 | https://github.com/apache/dolphinscheduler/pull/2656 | 050dae7ca4a1b6243fbc0dd9c4018d45e1655566 | d54aab5cd530b2e135a58fbd6b22564583b5abb8 | "2020-04-30T01:27:32Z" | java | "2020-05-09T07:03:02Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,578 | ["dolphinscheduler-ui/src/js/conf/home/pages/projects/pages/definition/pages/list/_source/list.vue", "dolphinscheduler-ui/src/js/module/i18n/locale/en_US.js", "dolphinscheduler-ui/src/js/module/i18n/locale/zh_CN.js"] | [BUG]wrong description of work flow copy tips | ![image](https://user-images.githubusercontent.com/29528966/80588031-28815900-8a4a-11ea-8c41-595890f0c529.png)
version:
dev
i think the tips should be "work flow copy" | https://github.com/apache/dolphinscheduler/issues/2578 | https://github.com/apache/dolphinscheduler/pull/2612 | 6a92bef5e36dd6c7100517cfa516ca9c8603d950 | fadfb28187f48648230094e05f946d2b41e8f67a | "2020-04-29T10:50:58Z" | java | "2020-05-06T13:33:08Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,574 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/NetUtils.java"] | [Feature]Configurable registration ipaddress | **Is your feature request related to a problem? Please describe.**
on macos,OSUtils.getHost() returns diffrent ip in running time. Also,the method OSUtils.getHost() didn't
perform well in container situation like docker ,some error may happen
**Describe the solution you'd like**
provide a param like register-ip to specific the ip which will be registried on zk
**Describe alternatives you've considered**
provide a param like networkinterface to specific the networkinterface which will be registried on zk
**Additional context**
<img width="1467" alt="8C1E5A5B-CC64-40FE-9049-5FC6154E72FE" src="https://user-images.githubusercontent.com/42403258/80572245-80ab6180-8a30-11ea-9525-73b33f1bf49e.png">
<img width="1481" alt="25DECE0A-2A92-479F-A76F-7DAEB8F691FF" src="https://user-images.githubusercontent.com/42403258/80572256-8608ac00-8a30-11ea-8784-eeb88c0fb7ea.png">
英文不好,简单的说就是可以指定注册到zk上的ip或可选的网卡配置 | https://github.com/apache/dolphinscheduler/issues/2574 | https://github.com/apache/dolphinscheduler/pull/3186 | 6c9ac84f73a20717ab1014fe8c09e98668262baa | 6f9970b189d71d043e79200a70a95f2f33ad10f4 | "2020-04-29T07:48:39Z" | java | "2020-07-13T10:51:38Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,559 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessDefinitionService.java", "sql/dolphinscheduler_mysql.sql"] | [Feature]unique processdefinition name in the same project | **branch**
dev
**Is your feature request related to a problem? Please describe.**
if the same name in one project ,im hard to recognize any one . And its usually caused by mistake
**Describe the solution you'd like**
unique processDifinition name in one project
**Additional context**
name suffix is also good | https://github.com/apache/dolphinscheduler/issues/2559 | https://github.com/apache/dolphinscheduler/pull/2617 | 33658d57fd9149cc8321e53683eeb756076fe7d7 | 6127f3a4609cda2937f47432e5c2c2ddb75c4452 | "2020-04-28T10:34:05Z" | java | "2020-05-07T09:18:42Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,545 | ["dolphinscheduler-ui/src/js/conf/home/pages/security/pages/users/_source/createUser.vue"] | [BUG] The create user is always loading when the queue does not select any value | **The create user is always loading when the queue does not select any value**
Prerequisite: queue is not required to fill
**Steps to reproduce the issue**
1. Click create user
2. User name, password, tenant, email mobile phone number are filled in correctly
3. Only the queue is empty ()
4. submit
5. error: Display "loading" all the time
**expected result**
Successfully create the user when the queue is empty, so I can use the tenant's queue, because the priority of the user's queue is higher than that of the tenant's queue.
**DolphinScheduler1.2.0**
**Screenshots**
![1587983909(1)](https://user-images.githubusercontent.com/51871547/80363158-63eb1e80-88b6-11ea-83cc-dc37183f4a76.jpg)
| https://github.com/apache/dolphinscheduler/issues/2545 | https://github.com/apache/dolphinscheduler/pull/2558 | 632b2b503a7d4fc4d9a24961d5e4139b8373ccbc | 697ea0f65625995a07b03ef892cf0f841b8926dd | "2020-04-27T10:39:35Z" | java | "2020-05-07T03:51:42Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,499 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/processor/TaskCallbackService.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"] | [BUG]The task is in progress, the master and worker hang up , start the master and worker again, the process instance and task are not fault-tolerant | 1.The task is in progress
2. Worker hangs first, then hangs master
3.start the master and worker again, the process instance and task are not fault-tolerant,Status has been in progress
![image](https://user-images.githubusercontent.com/55787491/80054593-3e76b180-8552-11ea-9779-b243169b6e44.png)
![image](https://user-images.githubusercontent.com/55787491/80054556-299a1e00-8552-11ea-998c-9696719264a4.png)
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2499 | https://github.com/apache/dolphinscheduler/pull/2833 | f25069bf839cb76c6dd3bcd58887040f8317d7f6 | d67436ffad7afe4985d843bc63cab260667ed7d7 | "2020-04-23T03:05:33Z" | java | "2020-05-28T04:31:12Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,492 | ["script/dolphinscheduler-daemon.sh"] | [BUG] sh stop-all.sh, the master service is not killed | 1. sh stop-all.sh
2. Check the master service,the master service is not killed
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2492 | https://github.com/apache/dolphinscheduler/pull/2497 | e837a73fcd823be5f7488d0b36085a044239defe | 21c10f886288ee6667f052eff294da7964de8e64 | "2020-04-22T03:20:31Z" | java | "2020-04-23T09:12:16Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,481 | ["dolphinscheduler-server/src/main/resources/config/install_config.conf", "install.sh"] | [BUG] the Mysql needs to configure with“allowMultiQueries = true”, | 1.Since MYSQL does not support batch upload, the data source needs to be configured with“allowMultiQueries = true”, otherwise an error will be occurred when deleting resource files。mysql configuration is as follows:
spring.datasource.url=jdbc:mysql://192.168.xx.xx:3306/dolphinscheduler?useUnicode=true&characterEncoding=UTF-8&allowMultiQueries=true
2.It is recommended to change the database name to configurable
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2481 | https://github.com/apache/dolphinscheduler/pull/2573 | b5dbe94f07166d7dfd4dad531c2763bc39951815 | 632b2b503a7d4fc4d9a24961d5e4139b8373ccbc | "2020-04-21T03:57:53Z" | java | "2020-05-07T01:48:05Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,464 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ExecutionStatus.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/DependentTaskExecThread.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/utils/DependentExecute.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/master/DependentTaskTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java"] | [BUG] dependent task failed when conditions task exists | ![image](https://user-images.githubusercontent.com/29528966/79708968-8ba91800-82f3-11ea-8bfb-ee1757bb2d80.png)
description:
1. work flow A have a conditions task.
2. work flow B have a dependent task that depend work A
3. work flow B would failed always.
| https://github.com/apache/dolphinscheduler/issues/2464 | https://github.com/apache/dolphinscheduler/pull/2768 | 7a05c007b45ea742e3ed1a7558c1a641515c140c | 184d64e85291b1e8fb82494bf5a8e2ea755a3dc1 | "2020-04-20T02:48:35Z" | java | "2020-05-21T02:34:28Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,450 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java"] | [BUG] cannot complement data for one day |
cannot complement data for one day.
![image](https://user-images.githubusercontent.com/29528966/79549206-443f4380-80c9-11ea-9ec9-678b65095969.png)
| https://github.com/apache/dolphinscheduler/issues/2450 | https://github.com/apache/dolphinscheduler/pull/2493 | 2f5427ca33b8e929d58412699699141191c640b4 | b5fdce4164385f1df2ddb25c9441b50ea28ce681 | "2020-04-17T08:35:59Z" | java | "2020-04-23T02:23:32Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,442 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ResourcesService.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/ResourcesServiceTest.java"] | [BUG] update the directory of resource is error |
update the directory occasionally appears the resource file does't exist, and the actual update directory is successful
![image](https://user-images.githubusercontent.com/55787491/79429815-9feecb80-7ffa-11ea-9c00-41e88eed05e9.png)
![image](https://user-images.githubusercontent.com/55787491/79429960-cd3b7980-7ffa-11ea-958e-32cefebfeffe.png)
![image](https://user-images.githubusercontent.com/55787491/79430009-e17f7680-7ffa-11ea-91ea-87c9d91237b1.png)
**Which version of Dolphin Scheduler:**
-[dev]
| https://github.com/apache/dolphinscheduler/issues/2442 | https://github.com/apache/dolphinscheduler/pull/2524 | c50ad1240c4789403e9518c855c0217fc9030b5b | e6dec8d2a7a6d39280675d225ec818e0cc7012be | "2020-04-16T08:01:56Z" | java | "2020-04-27T06:16:21Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,350 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"] | [BUG] master fault tolerance error | 1. Start one master1 and two workers
2. Task setting timing, executed once every 1 minute, online timing
3. There are 3 workflow instances running on the master1 service, and the task shell_task_1 of the workflow instance is also in the "running" state.
4. Start the master2 service, the host of the workflow instance changes from master1 to master2, and the task shell_task_1 also starts fault-tolerant processing, as shown in the following figure, and finally shell_task_1 is executed 3 times:
===============================================
1.启动一台master1 , 2台worker
2.任务设置定时,1分钟执行一次,上线定时
3.有3个工作流实例在master1服务上运行,其中工作流实例的任务shell_task_1也处于“正在运行”状态
4.启动master2服务,工作流实例的host从master1变为master2,任务shell_task_1也开始容错处理,如下图所示,最终shell_task_1被执行3次:
===============================================
![image](https://user-images.githubusercontent.com/55787491/78106433-f4545180-7425-11ea-8bc6-ebcf916236f8.png)
![image](https://user-images.githubusercontent.com/55787491/78106449-fe765000-7425-11ea-8dd8-3c14ec90d4fb.png)
![image](https://user-images.githubusercontent.com/55787491/78106564-3d0c0a80-7426-11ea-956e-42b2b19a01cd.png)
**Which version of Dolphin Scheduler:**
-[refactor-worker]
| https://github.com/apache/dolphinscheduler/issues/2350 | https://github.com/apache/dolphinscheduler/pull/2375 | c9620ab557ec4c8d0bef1c87c93348b238a7bd8e | 785c34bc66b04dbccbd64639850dc44d67957aba | "2020-04-01T06:38:43Z" | java | "2020-04-07T08:23:31Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,349 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/zk/ZKMasterClient.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/zk/AbstractZKClient.java"] | [BUG]Visit the worker page of the monitoring center, a null pointer occur |
![image](https://user-images.githubusercontent.com/55787491/78097549-2a3a0b80-740f-11ea-8302-5c63fa1b79dc.png)
![image](https://user-images.githubusercontent.com/55787491/78097589-3faf3580-740f-11ea-82d2-4249cef0e876.png)
**Which version of Dolphin Scheduler:**
-[refactor-worker]
| https://github.com/apache/dolphinscheduler/issues/2349 | https://github.com/apache/dolphinscheduler/pull/2375 | c9620ab557ec4c8d0bef1c87c93348b238a7bd8e | 785c34bc66b04dbccbd64639850dc44d67957aba | "2020-04-01T03:53:07Z" | java | "2020-04-07T08:23:31Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,282 | ["dolphinscheduler-dao/src/main/resources/application.properties", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentExecute.java", "dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentTask.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/dependent/DependentTaskTest.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "pom.xml"] | this workflow is bug , I think it's a very serious problem | Is I also found a problem, it is a bug, is I have two workflow of a and b, then a workflow Riga, a1 node b work new b1 task dependent nodes, type selection, the chosen today, relying on a1, my situation is such, a workflow, I have the day before the creation of a1 run through a process, and then I run b process, theory should be run failed, but in fact was a success.I am also drunk, similarly I choose the type of b1 yesterday also can run successfully, but the first three days before the election run failed.That logo is faild | https://github.com/apache/dolphinscheduler/issues/2282 | https://github.com/apache/dolphinscheduler/pull/2329 | 949b8ef17d2b734b239ce31c997d7084868347b7 | 69e000b54214e8331ede69bdce9710b8418e960e | "2020-03-23T08:00:51Z" | java | "2020-04-02T16:16:01Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,178 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/sql/SqlTask.java"] | [BUG] SqlTask kerberos authentication process | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
When the keytab is expired or deactivated, other tasks that did not require authentication also failed. Obviously there is something wrong with the kerberos authentication process and it should only do it when it is needed.
**Which version of Dolphin Scheduler:**
-[1.2.1-release]
**Requirement or improvement
- Change CommonUtils.loadKerberosConf() call scope;
| https://github.com/apache/dolphinscheduler/issues/2178 | https://github.com/apache/dolphinscheduler/pull/2321 | a851168a350e300becb3452e91871220ffa3a5fc | d4735334a1986fedd5b92d185dc6d46be93cb071 | "2020-03-14T11:25:36Z" | java | "2020-03-28T09:42:33Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,111 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/OSUtils.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/utils/process/ProcessImplForWin32.java", "dolphinscheduler-server/src/test/java/org/apache/dolphinscheduler/server/worker/task/shell/ShellTaskTest.java"] | [BUG] sun.misc.JavaIOFileDescriptorAccess is not portable | Current implementation relies on `sun.misc.JavaIOFileDescriptorAccess` which is only accessible on oraclejdk8.
Basically the demand is getting & setting `field` field of `FileDescriptor`, so we can directly do that with reflection.
Though, I suspect the necessity we introduce `ProcessImplForWin32`. Maybe we could have a better way to support worker server to run bat script. | https://github.com/apache/dolphinscheduler/issues/2111 | https://github.com/apache/dolphinscheduler/pull/2113 | 450a1f56fc73f088fce89a343a0b008706f2088c | 9224b49b58b756d22c75d8929108f716283282b4 | "2020-03-08T05:09:46Z" | java | "2020-03-09T11:06:41Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 2,101 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ProcessInstanceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java", "dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/task/conditions/ConditionsParameters.java", "dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessService.java", "dolphinscheduler-service/src/test/java/org/apache/dolphinscheduler/service/process/ProcessServiceTest.java"] | [BUG] After renaming the branch name, the name of Branch Flow does not change | 更改任务名称后,分支流转的名称还是更改前的任务名称
![image](https://user-images.githubusercontent.com/55787491/76071071-9e2ff200-5fd0-11ea-8702-e7b357d7b060.png)
**Which version of Dolphin Scheduler:**
-[1.2.0_release]
| https://github.com/apache/dolphinscheduler/issues/2101 | https://github.com/apache/dolphinscheduler/pull/4555 | cfd9db5555b3d8f9f33f25a9272c8741115a9336 | 14d49bc584685a33e2952573a0cb6e88377ab9f9 | "2020-03-06T09:35:19Z" | java | "2021-02-02T08:07:37Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,996 | ["install.sh"] | [BUG] install.sh will happen "sh: bin/dolphinscheduler-daemon.sh: No such file or directory" when first deploy | **Describe the bug**
when I first deploy the DolphinScheduler, I find that
```
# 3,stop server
echo "3,stop server"
sh ${workDir}/script/stop-all.sh
...
# 5,scp resources
echo "5,scp resources"
sh ${workDir}/script/scp-hosts.sh
if [ $? -eq 0 ]
then
echo 'scp copy completed'
else
echo 'scp copy failed to exit'
exit -1
fi
```
**Which version of Dolphin Scheduler:**
-[1.2.0]
**how to solve**
the 3 step should change position to the 5 step, becase on the 3 step, the shell scripts not exists in the install path | https://github.com/apache/dolphinscheduler/issues/1996 | https://github.com/apache/dolphinscheduler/pull/1998 | b4f2e5f4210ce70d6ec50e68fd177ee26841fc03 | 5ecd3b30b923dc4dfa6ac846b6ac44bfb2f8e11f | "2020-02-22T12:20:33Z" | java | "2020-02-23T08:59:24Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,968 | ["dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.js", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/dag.vue", "dolphinscheduler-ui/src/js/conf/home/pages/dag/_source/plugIn/jsPlumbHandle.js"] | [BUG] The task details window did not close properly. |
**Describe the bug**
The task details window did not close properly.
**To Reproduce**
1. Go to the page of the definition create or definition edit.
2. Drag to create a new task node or edit an exist node. And the task details window will be open.
3. Delete the task node or click the DataSource menu.
4. See error. The task details window still open.
**Which version of Dolphin Scheduler:**
-[dev]
**Requirement or improvement
The task details window should be close. | https://github.com/apache/dolphinscheduler/issues/1968 | https://github.com/apache/dolphinscheduler/pull/1969 | d7d7e95498cd69132660c7287052bb328a76f4ec | afd5c75cd27c9fe1a7efcafbed92bf28fc3996e5 | "2020-02-17T03:36:53Z" | java | "2020-02-17T11:09:10Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,682 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/worker/task/AbstractTask.java"] | [suggest] The method getcurtaskparamsclass() of class abstracttask is the same as the function of class taskparametersutils Functions can be replaced | *For better global communication, please give priority to using English description, thx! *
**Describe the bug**
The method getCurTaskParamsClass() of class AbstractTask is the same as the function of class TaskParametersUtils Functions can be replaced
**To Reproduce**
**Expected behavior**
- Delete the method getcurtaskparamsclass() of class abstracttask
**Screenshots**
If applicable, add screenshots to help explain your problem.
**Which version of Dolphin Scheduler:**
-[1.2.1-dev]
**Additional context**
**Requirement or improvement
Getcurtaskparamsclass() function of class abstracttask is replaced by taskparametersutils
| https://github.com/apache/dolphinscheduler/issues/1682 | https://github.com/apache/dolphinscheduler/pull/4262 | 3bcd3fbcd344983ed35f997bed1fea2c0cf6055d | 24864512212a94f53da32eb20dc56673f960547a | "2020-01-02T08:42:35Z" | java | "2020-12-20T13:52:52Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,578 | [".github/workflows/ci_backend.yml", ".gitignore", "dolphinscheduler-dist/release-docs/LICENSE", "dolphinscheduler-dist/release-docs/licenses/LICENSE-lombok.txt", "dolphinscheduler-ui/package.json", "pom.xml", "tools/dependencies/check-LICENSE.sh", "tools/dependencies/known-dependencies.txt"] | [CI/CD]Checking the dependency licenses | Track the root issue #1460
Apache has strict requirements for license, so ci needs to verify license, you can refer to skywalking or other apache dependence license check flow.
skywalking link: https://github.com/apache/skywalking/blob/master/tools/dependencies/check-LICENSE.sh
if you want to contribute, you may reply "i want to implement it" | https://github.com/apache/dolphinscheduler/issues/1578 | https://github.com/apache/dolphinscheduler/pull/2552 | 6e81dd3b582546c9048b3508198dddcfbc1d3282 | 6e08b29254f3a5c340172c34a6a67e3cc8af0c48 | "2019-12-25T13:53:23Z" | java | "2020-05-02T14:19:20Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,442 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterSchedulerThread.java"] | [BUG] code comment error |
**Describe the bug**
in this class: org.apache.dolphinscheduler.server.master.runner.MasterSchedulerThread. the line number 104, zkMasterClient.getMasterLockPath() The lock path obtained may should be /dolphinscheduler/lock/masters, but in the comment, is's /dolphinscheduler/lock/failover/master, I think it's easy to mislead people who read the source code, please check this, if it does, I can open a pr to fix it
**To Reproduce**
None
**Expected behavior**
Node
**Screenshots**
None
**Which version of Dolphin Scheduler:**
latest version
**Additional context**
None
**Requirement or improvement
None
| https://github.com/apache/dolphinscheduler/issues/1442 | https://github.com/apache/dolphinscheduler/pull/1446 | a1ded5ee041a387d56757fcdd27e39efd3a6000a | 9a3a6f5a3d5ec613b49ae1a5a947d58c351f1fc7 | "2019-12-11T03:47:22Z" | java | "2019-12-12T06:20:27Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,441 | ["dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/Constants.java"] | [Feature] add user error when user name contains '.' | **Is your feature request related to a problem? Please describe.**
add a user when user name contains '.'
i think maybe the username regex string is error.
| https://github.com/apache/dolphinscheduler/issues/1441 | https://github.com/apache/dolphinscheduler/pull/1445 | b276ece5727bdf7cecc07bfc888f27cb75726b65 | a1ded5ee041a387d56757fcdd27e39efd3a6000a | "2019-12-11T03:07:47Z" | java | "2019-12-12T06:19:55Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,399 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ResourcesController.java"] | [BUG] The wrong field order in logger.info | **Describe the bug**
The method onlineCreateResource in class ResourcesController,The logger.info has wrong field order with fileName and type.
**Screenshots**
<img width="1021" alt="" src="https://user-images.githubusercontent.com/3699743/70215243-0f64cc80-1778-11ea-9ec5-f6a38559b051.png">
**Which version of Dolphin Scheduler:**
- [dev-db branch]
| https://github.com/apache/dolphinscheduler/issues/1399 | https://github.com/apache/dolphinscheduler/pull/1400 | b3a0e1fd148c876d61bce92fea14528c3fb2cf45 | f134453bb838c76f046fc450ef15afccd857074e | "2019-12-05T07:59:57Z" | java | "2019-12-05T09:04:54Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1,336 | ["dolphinscheduler-server/src/main/java/org/apache/dolphinscheduler/server/master/runner/MasterExecThread.java"] | [BUG] [api]Dependent execution fails after task performs serial complement |
**To Reproduce**
1. A task depends on B task, the deviation range is the first 3 days
2. The serial complement of 3 days before the B task execution
3. Run workflow, dependent execution fails
![image](https://user-images.githubusercontent.com/55787491/69607569-74297400-1060-11ea-9d15-8175e79056ff.png)
**Which version of Dolphin Scheduler:**
-[1.2.0]
| https://github.com/apache/dolphinscheduler/issues/1336 | https://github.com/apache/dolphinscheduler/pull/3331 | 624f0aeab9621abbbc9584c4a3167cb1bd2dcf00 | 5f725aa28b2edbd246480a554ac7822bf07fbbfd | "2019-11-26T07:23:55Z" | java | "2020-07-29T07:37:49Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 516 | ["escheduler-server/src/main/java/cn/escheduler/server/utils/LoggerUtils.java"] | The task instance of MR cannot stop in some cases | The task instance of MR cannot stop in some cases | https://github.com/apache/dolphinscheduler/issues/516 | https://github.com/apache/dolphinscheduler/pull/560 | f880a76d7a3a95d4b425a16853456025292b8c03 | d3e59773085cf287e908a789b58a14285a57da43 | "2019-07-04T04:51:57Z" | java | "2019-07-10T09:21:12Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 319 | ["dolphinscheduler-ui-next/src/locales/modules/en_US.ts", "dolphinscheduler-ui-next/src/locales/modules/zh_CN.ts", "dolphinscheduler-ui-next/src/views/security/user-manage/components/user-detail-modal.tsx"] | Stand-alone fault tolerance (running, fault tolerance...)(单机容错(正在运行、容错。。。)) | https://github.com/apache/dolphinscheduler/issues/319 | https://github.com/apache/dolphinscheduler/pull/9683 | a51b710b1c8ae43d9e9bcbc386af4d81fb7e6b65 | 86bdb826dc4df912a60d1cd8bbaffc7ad2b6913f | "2019-05-21T04:41:50Z" | java | "2022-04-24T06:14:12Z" |
|
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 104 | ["dolphinscheduler-ui/src/views/datasource/list/detail.tsx", "dolphinscheduler-ui/src/views/datasource/list/use-form.ts"] | One-click deployment optimization, use the boot, target 30 minutes to get started (一键部署优化,使用上引导,目标30分钟上手) | One-click deployment optimization, use the boot, target 30 minutes to get started
---
一键部署优化,使用上引导,目标30分钟上手 | https://github.com/apache/dolphinscheduler/issues/104 | https://github.com/apache/dolphinscheduler/pull/10876 | 1edbb5e333eb91bc04002d7f15b15c8511fd7eed | 56fe11ecf9e50bdd984920a065b8ba0680e741f1 | "2019-04-22T14:32:40Z" | java | "2022-07-12T01:18:10Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 15 | ["dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/K8sNamespaceController.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/K8sNamespaceService.java", "dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java", "dolphinscheduler-api/src/test/java/org/apache/dolphinscheduler/api/service/K8SNamespaceServiceTest.java"] | Missing LogParameter and RetStrInfo(缺少LogParameter和RetStrInfo) | LogViewServiceGrpc cannot find LogParameter and RetStrInfo below
---
LogViewServiceGrpc 下面找不到LogParameter和RetStrInfo | https://github.com/apache/dolphinscheduler/issues/15 | https://github.com/apache/dolphinscheduler/pull/15546 | 25810a81dc528feedd81e44f8f57469286c0e8c7 | 2f66a667ba6bed20003cfb17af3f347166e678c1 | "2019-04-04T03:44:51Z" | java | "2024-02-01T02:39:54Z" |
closed | apache/dolphinscheduler | https://github.com/apache/dolphinscheduler | 1 | ["docs/configs/docsdev.js"] | The link address is missing(链接地址缺少) | https://github.com/apache/dolphinscheduler/issues/1 | https://github.com/apache/dolphinscheduler/pull/15660 | 502b49a1cb845c04c6b754e88748d2de8ef84508 | 040ab34bafa25c5fd17f4ca172f05f55aa2ab446 | "2019-03-02T03:25:40Z" | java | "2024-03-04T08:49:22Z" |